Source/core/html/track/TextTrackList.idl - Issue 284513003: Implement AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/track/TextTrackList.idl

Issue 284513003: Implement AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: oilpan tracing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/html/track/AudioTrackList.cpp ('K') | « Source/core/html/track/AudioTrackList.idl ('k') | Source/core/html/track/TrackBase.h » ('j') | Source/core/html/track/TrackBase.h » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Apple Inc. All rights reserved.	2 * Copyright (C) 2011 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 10 matching lines...) Expand all Loading...
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

24 */	24 */

25	25

26 [	26 [

27 SetWrapperReferenceFrom=owner,	27 SetWrapperReferenceFrom=owner,

28 ] interface TextTrackList : EventTarget {	28 ] interface TextTrackList : EventTarget {

29 readonly attribute unsigned long length;	29 readonly attribute unsigned long length;

30 getter TextTrack item(unsigned long index);	30 getter TextTrack item(unsigned long index);

31 TextTrack getTrackById(DOMString id);	31 TextTrack? getTrackById(DOMString id);
	haraken 2014/06/12 01:22:07 Would you add a test case for this? Would you add a test case for this? philipj_slow 2014/06/12 14:53:02 This was a drive-by fix, I've separated it out int Show quoted text On 2014/06/12 01:22:07, haraken wrote: > > Would you add a test case for this? This was a drive-by fix, I've separated it out into https://codereview.chromium.org/336523002/ with a test. I've added tests for Audio/VideoTrackList.getTrackById() to this review.
32	32

33 attribute EventHandler onaddtrack;	33 attribute EventHandler onaddtrack;

34 attribute EventHandler onchange;	34 attribute EventHandler onchange;

35 attribute EventHandler onremovetrack;	35 attribute EventHandler onremovetrack;

36 };	36 };

37

OLD	NEW