Source/core/html/track/AudioTrackList.idl - Issue 284513003: Implement AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/track/AudioTrackList.idl

Issue 284513003: Implement AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: use oilpan transitional types Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 RuntimeEnabled=AudioVideoTracks,
	sof 2014/05/22 11:47:36 Add [WillBeGarbageCollected] Add [WillBeGarbageCollected] philipj_slow 2014/05/22 12:51:02 As discussed on IRC with sof, this is apparently n Show quoted text On 2014/05/22 11:47:36, sof wrote: > Add [WillBeGarbageCollected] As discussed on IRC with sof, this is apparently not needed: 12:42 <@philipj> and is it an oversight that TextTrackList.idl did not get [WillBeGarbageCollected]? 12:42 < sof> hmm..wait a sec 12:44 < sof> ah, TextTrackList is an EventTarget, which is a hybrid refcounted-GC thing currently. 12:45 <@philipj> ah, but so is AudioTrackList and VideoTrackList, so... what does that mean, exactly? 12:45 < sof> so you don't need [WillBeGarbageCollected] on the List interfaces, just "leaf" track objects here. sof* 2014/05/22 12:51:56 Sorry, let's leave this EventTarget-derived interf Show quoted text On 2014/05/22 11:47:36, sof wrote: > Add [WillBeGarbageCollected] Sorry, let's leave this EventTarget-derived interface without [WillBeGarbageCollected]. When EventTarget switches, this will automatically get it also. This applies to VideoTrackList.idl also; sorry about the confusion.
	7 ] interface AudioTrackList : EventTarget {

	8 readonly attribute unsigned long length;

	9 getter AudioTrack (unsigned long index);

	10 AudioTrack? getTrackById(DOMString id);

	11

	12 attribute EventHandler onchange;

	13 attribute EventHandler onaddtrack;

	14 attribute EventHandler onremovetrack;

	15 };

OLD	NEW