Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: base/memory/shared_memory_nacl.cc

Issue 2845113005: Replace base::SharedMemory read-only methods with GetReadOnlyHandle. (Closed)
Patch Set: Comments from thakis. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/memory/shared_memory_mac_unittest.cc ('k') | base/memory/shared_memory_posix.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/shared_memory.h" 5 #include "base/memory/shared_memory.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <fcntl.h> 8 #include <fcntl.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 #include <sys/mman.h> 10 #include <sys/mman.h>
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 return handle_copy; 118 return handle_copy;
119 } 119 }
120 120
121 void SharedMemory::Close() { 121 void SharedMemory::Close() {
122 if (shm_.IsValid()) { 122 if (shm_.IsValid()) {
123 shm_.Close(); 123 shm_.Close();
124 shm_ = SharedMemoryHandle(); 124 shm_ = SharedMemoryHandle();
125 } 125 }
126 } 126 }
127 127
128 SharedMemoryHandle SharedMemory::GetReadOnlyHandle() {
129 // Untrusted code can't create descriptors or handles, which is needed to
130 // drop permissions.
131 return SharedMemoryHandle();
132 }
133
128 bool SharedMemory::ShareToProcessCommon(ProcessHandle process, 134 bool SharedMemory::ShareToProcessCommon(ProcessHandle process,
129 SharedMemoryHandle *new_handle, 135 SharedMemoryHandle* new_handle,
130 bool close_self, 136 bool close_self) {
131 ShareMode share_mode) {
132 if (share_mode == SHARE_READONLY) {
133 // Untrusted code can't create descriptors or handles, which is needed to
134 // drop permissions.
135 return false;
136 }
137
138 *new_handle = shm_.Duplicate(); 137 *new_handle = shm_.Duplicate();
139
140 if (close_self) { 138 if (close_self) {
141 Unmap(); 139 Unmap();
142 Close(); 140 Close();
143 } 141 }
144 return new_handle->IsValid(); 142 return new_handle->IsValid();
145 } 143 }
146 144
147 } // namespace base 145 } // namespace base
OLDNEW
« no previous file with comments | « base/memory/shared_memory_mac_unittest.cc ('k') | base/memory/shared_memory_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698