Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4042)

Unified Diff: chrome/renderer/extensions/platform_keys_natives.cc

Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome (Closed)
Patch Set: Address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/platform_keys_natives.cc
diff --git a/chrome/renderer/extensions/platform_keys_natives.cc b/chrome/renderer/extensions/platform_keys_natives.cc
index 1009974c028ac8bfdf7819196b7b9da748d4de78..c0da6678c5ea80ad9d39a7dcadf598ca2ea3d3b8 100644
--- a/chrome/renderer/extensions/platform_keys_natives.cc
+++ b/chrome/renderer/extensions/platform_keys_natives.cc
@@ -6,6 +6,7 @@
#include <memory>
#include <string>
+#include <utility>
#include "base/values.h"
#include "content/public/child/v8_value_converter.h"
@@ -82,7 +83,7 @@ std::unique_ptr<base::DictionaryValue> WebCryptoAlgorithmToBaseValue(
std::unique_ptr<base::DictionaryValue> hash_dict(new base::DictionaryValue);
hash_dict->SetStringWithoutPathExpansion("name", hash_info->name);
- dict->SetWithoutPathExpansion("hash", hash_dict.release());
+ dict->SetWithoutPathExpansion("hash", std::move(hash_dict));
}
// Otherwise, |algorithm| is missing support here or no parameters were
// required.
« no previous file with comments | « chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc ('k') | chrome/test/chromedriver/chrome/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698