Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome (Closed)
Patch Set: Address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
diff --git a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
index 0c2e812e905712e7e34a4ad15360222534e0e39b..4788c993243ba448595a1913d8dc0f8cdd2e17fe 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
+++ b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
@@ -13,6 +13,7 @@
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h"
#include "base/task_scheduler/post_task.h"
+#include "base/values.h"
#include "chrome/browser/chromeos/arc/arc_session_manager.h"
#include "chrome/browser/chromeos/arc/arc_util.h"
#include "chrome/browser/chromeos/arc/policy/arc_policy_util.h"
@@ -71,8 +72,8 @@ class ScopedArcPrefUpdate : public DictionaryPrefUpdate {
base::DictionaryValue* dict = DictionaryPrefUpdate::Get();
base::DictionaryValue* dict_item = nullptr;
if (!dict->GetDictionaryWithoutPathExpansion(id_, &dict_item)) {
- dict_item = new base::DictionaryValue();
- dict->SetWithoutPathExpansion(id_, dict_item);
+ dict_item = dict->SetDictionaryWithoutPathExpansion(
+ id_, base::MakeUnique<base::DictionaryValue>());
}
return dict_item;
}
« no previous file with comments | « chrome/browser/ui/app_list/app_list_syncable_service.cc ('k') | chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698