chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc - Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc

Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome (Closed)

Patch Set: Address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.cc ('k') | chrome/browser/supervised_user/supervised_user_bookmarks_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc

diff --git a/chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc b/chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc

index 62b3ce4b58abb70801c3a022ea852e99d367438c..b3df0f91673c91b032021b4a7fc2d46533d17d5b 100644

--- a/chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc

+++ b/chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc

@@ -281,7 +281,7 @@ void SupervisedUserSyncService::UpdateSupervisedUserImpl(

DCHECK_EQ(add_user, !dict->HasKey(id));

base::DictionaryValue* entry = value.get();

- dict->SetWithoutPathExpansion(id, value.release());

+ dict->SetWithoutPathExpansion(id, std::move(value));

if (!sync_processor_)

return;