Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc

Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome (Closed)
Patch Set: Replace Set/Get pairs by new Set Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.cc ('K') | « chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc ('k') | chrome/browser/ui/webui/chromeos/network_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc b/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
index 3bae474ca267dbc62251c524b32294e20a277cd8..e6515a96805c4cc2b472e0ec3d460d7505157093 100644
--- a/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
@@ -79,7 +79,8 @@ void BaseWebUIHandler::ShowScreenWithData(OobeScreen screen,
base::DictionaryValue screen_params;
screen_params.SetString("id", GetOobeScreenName(screen));
if (data)
Nico 2017/05/02 19:00:34 nit: add {}
jdoerrie 2017/05/02 19:39:32 Done.
- screen_params.SetWithoutPathExpansion("data", data->DeepCopy());
+ screen_params.SetWithoutPathExpansion("data",
+ base::MakeUnique<base::Value>(*data));
web_ui()->CallJavascriptFunctionUnsafe("cr.ui.Oobe.showScreen",
screen_params);
}
« chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.cc ('K') | « chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc ('k') | chrome/browser/ui/webui/chromeos/network_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698