Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome

chrome/browser/signin/easy_unlock_service_regular.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/easy_unlock_service_regular.h"
 
 #include <stdint.h>
 
 #include <utility>
 
@@ skipping 216 matching lines @@
       pairing_dict->GetDictionary(kKeyPermitAccess, &permit_dict))
     return permit_dict;
 
   return NULL;
 }
 
 void EasyUnlockServiceRegular::SetPermitAccess(
     const base::DictionaryValue& permit) {
   DictionaryPrefUpdate pairing_update(profile()->GetPrefs(),
                                       prefs::kEasyUnlockPairing);
-  pairing_update->SetWithoutPathExpansion(kKeyPermitAccess, permit.DeepCopy());
+  pairing_update->SetWithoutPathExpansion(kKeyPermitAccess,
+                                          permit.CreateDeepCopy());

[vabr (Chromium), 2017/04/28 07:23:40]

I thought the best way to do a deep copy is
MakeUnique<Value>(permit)
?

(Also below.)

[jdoerrie, 2017/04/28 08:40:12]

Yes, you are right, thank you! I initially didn't do it, because |Set(key,
unique_ptr)| will also be deprecated at some point, which means this code will
need to touched again. I figured using |CreateDeepCopy| here will make it easier
to find and remove all these usages.

However, on second thought this is not a strong argument, and I should avoid
further usages of already deprecated methods. I will fix this in the next patch
set.

 }
 
 void EasyUnlockServiceRegular::ClearPermitAccess() {
   DictionaryPrefUpdate pairing_update(profile()->GetPrefs(),
                                       prefs::kEasyUnlockPairing);
   pairing_update->RemoveWithoutPathExpansion(kKeyPermitAccess, NULL);
 }
 
 const base::ListValue* EasyUnlockServiceRegular::GetRemoteDevices() const {
   const base::DictionaryValue* pairing_dict =
       profile()->GetPrefs()->GetDictionary(prefs::kEasyUnlockPairing);
   const base::ListValue* devices = NULL;
   if (pairing_dict && pairing_dict->GetList(kKeyDevices, &devices))
     return devices;
   return NULL;
 }
 
 void EasyUnlockServiceRegular::SetRemoteDevices(
     const base::ListValue& devices) {
   DictionaryPrefUpdate pairing_update(profile()->GetPrefs(),
                                       prefs::kEasyUnlockPairing);
   if (devices.empty())
     pairing_update->RemoveWithoutPathExpansion(kKeyDevices, NULL);
   else
-    pairing_update->SetWithoutPathExpansion(kKeyDevices, devices.DeepCopy());
+    pairing_update->SetWithoutPathExpansion(kKeyDevices,
+                                            devices.CreateDeepCopy());
 
 #if defined(OS_CHROMEOS)
   // TODO(tengs): Investigate if we can determine if the remote devices were set
   // from sync or from the setup app.
   if (short_lived_user_context_ && short_lived_user_context_->user_context()) {
     // We may already have the password cached, so proceed to create the
     // cryptohome keys for sign-in or the system will be hardlocked.
     chromeos::UserSessionManager::GetInstance()
         ->GetEasyUnlockKeyManager()
         ->RefreshKeys(
@@ skipping 318 matching lines @@
 
 cryptauth::CryptAuthDeviceManager*
 EasyUnlockServiceRegular::GetCryptAuthDeviceManager() {
   cryptauth::CryptAuthDeviceManager* manager =
       ChromeCryptAuthServiceFactory::GetInstance()
           ->GetForBrowserContext(profile())
           ->GetCryptAuthDeviceManager();
   DCHECK(manager);
   return manager;
 }