Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2845093003: Handle mixed in members (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle mixed in members + add equivalence testing for ElementEnvironment. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/5d71db8385cf912de32c61d4f9b5f6f6152dfd09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -74 lines) Patch
M pkg/compiler/lib/src/kernel/element_map.dart View 5 chunks +39 lines, -28 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 5 chunks +61 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 2 chunks +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 chunk +32 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
3 years, 7 months ago (2017-04-27 13:21:14 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-04-27 21:27:40 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-04-28 07:43:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d71db8385cf912de32c61d4f9b5f6f6152dfd09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698