Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: runtime/vm/weak_code.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)
Patch Set: Add StackFrameIterator::{ValidationPolicy,CrossThreadPolicy} enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/weak_code.cc
diff --git a/runtime/vm/weak_code.cc b/runtime/vm/weak_code.cc
index 544082644ef1cd6fabf049b05efd806ece516b9a..7f2f4064ff37f551baba76af68badef9dae5b39a 100644
--- a/runtime/vm/weak_code.cc
+++ b/runtime/vm/weak_code.cc
@@ -61,7 +61,8 @@ bool WeakCodeReferences::IsOptimizedCode(const Array& dependent_code,
void WeakCodeReferences::DisableCode() {
- const Array& code_objects = Array::Handle(array_.raw());
+ Thread* thread = Thread::Current();
+ const Array& code_objects = Array::Handle(thread->zone(), array_.raw());
if (code_objects.IsNull()) {
return;
}
@@ -70,7 +71,8 @@ void WeakCodeReferences::DisableCode() {
// Disable all code on stack.
Code& code = Code::Handle();
{
- DartFrameIterator iterator;
+ DartFrameIterator iterator(thread,
+ StackFrameIterator::kNoCrossThreadIteration);
StackFrame* frame = iterator.NextFrame();
while (frame != NULL) {
code = frame->LookupDartCode();
« no previous file with comments | « runtime/vm/thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698