Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: runtime/vm/stack_trace.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)
Patch Set: Add StackFrameIterator::{ValidationPolicy,CrossThreadPolicy} enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stack_frame_test.cc ('k') | runtime/vm/thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_trace.cc
diff --git a/runtime/vm/stack_trace.cc b/runtime/vm/stack_trace.cc
index c746d50104a00f6836daa4ffbaefa83c7f2f1706..e0c77177b2013d97187f3fc0d042c4272ba494c6 100644
--- a/runtime/vm/stack_trace.cc
+++ b/runtime/vm/stack_trace.cc
@@ -13,7 +13,8 @@ intptr_t StackTraceUtils::CountFrames(Thread* thread,
const Function& async_function) {
Zone* zone = thread->zone();
intptr_t frame_count = 0;
- StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
+ StackFrameIterator frames(StackFrameIterator::kDontValidateFrames, thread,
+ StackFrameIterator::kNoCrossThreadIteration);
StackFrame* frame = frames.NextFrame();
ASSERT(frame != NULL); // We expect to find a dart invocation frame.
Code& code = Code::Handle(zone);
@@ -48,7 +49,8 @@ intptr_t StackTraceUtils::CollectFrames(Thread* thread,
intptr_t count,
int skip_frames) {
Zone* zone = thread->zone();
- StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
+ StackFrameIterator frames(StackFrameIterator::kDontValidateFrames, thread,
+ StackFrameIterator::kNoCrossThreadIteration);
StackFrame* frame = frames.NextFrame();
ASSERT(frame != NULL); // We expect to find a dart invocation frame.
Function& function = Function::Handle(zone);
« no previous file with comments | « runtime/vm/stack_frame_test.cc ('k') | runtime/vm/thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698