Fix asserts in StackFrameIterator which were effectively disabled

runtime/vm/exceptions.cc

Index: runtime/vm/exceptions.cc
diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc
index 67afc0ca69098fbc5d2414760bee113f3dfde966..2ebff21412afd94dee4e62b8c28ede78874b0452 100644
--- a/runtime/vm/exceptions.cc
+++ b/runtime/vm/exceptions.cc
@@ -128,7 +128,9 @@ void PreallocatedStackTraceBuilder::AddFrame(const Code& code,
 
 
 static void BuildStackTrace(StackTraceBuilder* builder) {
-  StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
+  StackFrameIterator frames(StackFrameIterator::kDontValidateFrames,
+                            Thread::Current(),
+                            StackFrameIterator::kNoCrossThreadIteration);
   StackFrame* frame = frames.NextFrame();
   ASSERT(frame != NULL);  // We expect to find a dart invocation frame.
   Code& code = Code::Handle();
@@ -169,7 +171,9 @@ class ExceptionHandlerFinder : public StackResource {
   // can continue in that frame. Sets 'needs_stacktrace' if there is no
   // cath-all handler or if a stack-trace is specified in the catch.
   bool Find() {
-    StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
+    StackFrameIterator frames(StackFrameIterator::kDontValidateFrames,
+                              Thread::Current(),
+                              StackFrameIterator::kNoCrossThreadIteration);
     StackFrame* frame = frames.NextFrame();
     if (frame == NULL) return false;  // No Dart frame.
     handler_pc_set_ = false;
@@ -347,7 +351,9 @@ class ExceptionHandlerFinder : public StackResource {
 static void FindErrorHandler(uword* handler_pc,
                              uword* handler_sp,
                              uword* handler_fp) {
-  StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
+  StackFrameIterator frames(StackFrameIterator::kDontValidateFrames,
+                            Thread::Current(),
+                            StackFrameIterator::kNoCrossThreadIteration);
   StackFrame* frame = frames.NextFrame();
   ASSERT(frame != NULL);
   while (!frame->IsEntryFrame()) {
@@ -400,7 +406,8 @@ static void ClearLazyDeopts(Thread* thread, uword frame_pointer) {
     // frames from the pending deopt table, but only after unmarking them so
     // any stack walk that happens before the stack is unwound will still work.
     {
-      DartFrameIterator frames(thread);
+      DartFrameIterator frames(thread,
+                               StackFrameIterator::kNoCrossThreadIteration);
       StackFrame* frame = frames.NextFrame();
       while ((frame != NULL) && (frame->fp() < frame_pointer)) {
         if (frame->IsMarkedForLazyDeopt()) {
@@ -669,7 +676,8 @@ void Exceptions::CreateAndThrowTypeError(TokenPosition location,
                                          const String& dst_name,
                                          const String& bound_error_msg) {
   ASSERT(!dst_name.IsNull());  // Pass Symbols::Empty() instead.
-  Zone* zone = Thread::Current()->zone();
+  Thread* thread = Thread::Current();
+  Zone* zone = thread->zone();
   const Array& args = Array::Handle(zone, Array::New(4));
 
   ExceptionType exception_type =
@@ -678,7 +686,8 @@ void Exceptions::CreateAndThrowTypeError(TokenPosition location,
           ? kCast
           : kType;
 
-  DartFrameIterator iterator;
+  DartFrameIterator iterator(thread,
+                             StackFrameIterator::kNoCrossThreadIteration);
   const Script& script = Script::Handle(zone, GetCallerScript(&iterator));
   intptr_t line = -1;
   intptr_t column = -1;