Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: runtime/lib/errors.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)
Patch Set: Add StackFrameIterator::{ValidationPolicy,CrossThreadPolicy} enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/errors.cc
diff --git a/runtime/lib/errors.cc b/runtime/lib/errors.cc
index d10df392e2d4e5aa0a3cf11a260fea310d1bcd3c..a4a738bd9862ce21888838c61b2c440568078071 100644
--- a/runtime/lib/errors.cc
+++ b/runtime/lib/errors.cc
@@ -75,7 +75,8 @@ DEFINE_NATIVE_ENTRY(AssertionError_throwNew, 3) {
const Instance& message = Instance::CheckedHandle(arguments->NativeArgAt(2));
const Array& args = Array::Handle(Array::New(5));
- DartFrameIterator iterator;
+ DartFrameIterator iterator(thread,
+ StackFrameIterator::kNoCrossThreadIteration);
iterator.NextFrame(); // Skip native call.
const Script& script = Script::Handle(FindScript(&iterator));
@@ -139,7 +140,8 @@ DEFINE_NATIVE_ENTRY(FallThroughError_throwNew, 1) {
const Array& args = Array::Handle(Array::New(2));
// Initialize 'url' and 'line' arguments.
- DartFrameIterator iterator;
+ DartFrameIterator iterator(thread,
+ StackFrameIterator::kNoCrossThreadIteration);
iterator.NextFrame(); // Skip native call.
const Script& script = Script::Handle(Exceptions::GetCallerScript(&iterator));
args.SetAt(0, String::Handle(script.url()));
@@ -165,7 +167,8 @@ DEFINE_NATIVE_ENTRY(AbstractClassInstantiationError_throwNew, 2) {
const Array& args = Array::Handle(Array::New(3));
// Initialize 'className', 'url' and 'line' arguments.
- DartFrameIterator iterator;
+ DartFrameIterator iterator(thread,
+ StackFrameIterator::kNoCrossThreadIteration);
iterator.NextFrame(); // Skip native call.
const Script& script = Script::Handle(Exceptions::GetCallerScript(&iterator));
args.SetAt(0, class_name);
« no previous file with comments | « no previous file | runtime/lib/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698