runtime/vm/simulator_mips.cc - Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/simulator_mips.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)

Patch Set: remote two assertions which cannot be made Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/simulator_mips.cc

diff --git a/runtime/vm/simulator_mips.cc b/runtime/vm/simulator_mips.cc

index f3c325f9e1a2a8aee6a0ba94b8f507bdd7163e2a..f3e6a9b19f58d33889c249ae6aedc33c2d42e2db 100644

--- a/runtime/vm/simulator_mips.cc

+++ b/runtime/vm/simulator_mips.cc

@@ -281,9 +281,9 @@ void SimulatorDebugger::PrintDartFrame(uword pc,

void SimulatorDebugger::PrintBacktrace() {

- StackFrameIterator frames(sim_->get_register(FP), sim_->get_register(SP),

- sim_->get_pc(),

- StackFrameIterator::kDontValidateFrames);

+ StackFrameIterator frames(

+ sim_->get_register(FP), sim_->get_register(SP), sim_->get_pc(),

+ StackFrameIterator::kDontValidateFrames, Thread::Current(), false);

StackFrame* frame = frames.NextFrame();

ASSERT(frame != NULL);

Function& function = Function::Handle();