Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: runtime/vm/profiler.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)
Patch Set: remote two assertions which cannot be made Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/profiler.cc
diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc
index 8bfd7299fe6575e1bdc291ee1df6a536b7d74fd9..434d84b81398ec38cf58111cf5404d75b677675a 100644
--- a/runtime/vm/profiler.cc
+++ b/runtime/vm/profiler.cc
@@ -451,8 +451,14 @@ class ProfilerDartStackWalker : public ProfilerStackWalker {
stack_lower_(stack_lower),
has_exit_frame_(exited_dart_code) {
if (exited_dart_code) {
+// On windows the profiler does not run on the thread being profiled.
+#if defined(_WIN32)
+ const bool kAllowIteratingOtherThread = true;
+#else
+ const bool kAllowIteratingOtherThread = false;
+#endif
StackFrameIterator iterator(StackFrameIterator::kDontValidateFrames,
- thread);
+ thread, kAllowIteratingOtherThread);
pc_ = NULL;
fp_ = NULL;
sp_ = NULL;
« runtime/vm/debugger.cc ('K') | « runtime/vm/os_win.cc ('k') | runtime/vm/runtime_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698