runtime/vm/deopt_instructions.cc - Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/deopt_instructions.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)

Patch Set: remote two assertions which cannot be made Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/deopt_instructions.cc

diff --git a/runtime/vm/deopt_instructions.cc b/runtime/vm/deopt_instructions.cc

index 1c6f754176fc5fff18fb28a6121ca76017768938..75d7e7180bdae9e91e8ffa1a967656bd04b869d1 100644

--- a/runtime/vm/deopt_instructions.cc

+++ b/runtime/vm/deopt_instructions.cc

@@ -416,7 +416,7 @@ intptr_t DeoptContext::MaterializeDeferredObjects() {

// Since this is the only step where GC can occur during deoptimization,

// use it to report the source line where deoptimization occured.

if (FLAG_trace_deoptimization || FLAG_trace_deoptimization_verbose) {

- DartFrameIterator iterator;

+ DartFrameIterator iterator(Thread::Current(), false);

StackFrame* top_frame = iterator.NextFrame();

ASSERT(top_frame != NULL);

const Code& code = Code::Handle(top_frame->LookupDartCode());