Fix asserts in StackFrameIterator which were effectively disabled

runtime/vm/profiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/address_sanitizer.h"
 #include "platform/memory_sanitizer.h"
 #include "platform/utils.h"
 
 #include "vm/allocation.h"
 #include "vm/atomic.h"
@@ skipping 433 matching lines @@
                             sample,
                             sample_buffer,
                             skip_count),
         pc_(reinterpret_cast<uword*>(pc)),
         fp_(reinterpret_cast<uword*>(fp)),
         sp_(reinterpret_cast<uword*>(sp)),
         stack_upper_(stack_upper),
         stack_lower_(stack_lower),
         has_exit_frame_(exited_dart_code) {
     if (exited_dart_code) {
+// On windows the profiler does not run on the thread being profiled.
+#if defined(_WIN32)
+      const StackFrameIterator::CrossThreadPolicy cross_thread_policy =
+          StackFrameIterator::kAllowCrossThreadIteration;
+#else
+      const StackFrameIterator::CrossThreadPolicy cross_thread_policy =
+          StackFrameIterator::kNoCrossThreadIteration;
+#endif
       StackFrameIterator iterator(StackFrameIterator::kDontValidateFrames,
-                                  thread);
+                                  thread, cross_thread_policy);
       pc_ = NULL;
       fp_ = NULL;
       sp_ = NULL;
       if (!iterator.HasNextFrame()) {
         return;
       }
       // Ensure we are able to get to the exit frame.
       StackFrame* frame = iterator.NextFrame();
       if (!frame->IsExitFrame()) {
         return;
@@ skipping 1138 matching lines @@
 
 
 ProcessedSampleBuffer::ProcessedSampleBuffer()
     : code_lookup_table_(new CodeLookupTable(Thread::Current())) {
   ASSERT(code_lookup_table_ != NULL);
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart