Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: runtime/vm/benchmark_test.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)
Patch Set: Add StackFrameIterator::{ValidationPolicy,CrossThreadPolicy} enums Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/stacktrace.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/benchmark_test.h" 5 #include "vm/benchmark_test.h"
6 6
7 #include "bin/builtin.h" 7 #include "bin/builtin.h"
8 #include "bin/file.h" 8 #include "bin/file.h"
9 #include "bin/isolate_data.h" 9 #include "bin/isolate_data.h"
10 10
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 398
399 // 399 //
400 // Measure frame lookup during stack traversal. 400 // Measure frame lookup during stack traversal.
401 // 401 //
402 static void StackFrame_accessFrame(Dart_NativeArguments args) { 402 static void StackFrame_accessFrame(Dart_NativeArguments args) {
403 const int kNumIterations = 100; 403 const int kNumIterations = 100;
404 Code& code = Code::Handle(); 404 Code& code = Code::Handle();
405 Timer timer(true, "LookupDartCode benchmark"); 405 Timer timer(true, "LookupDartCode benchmark");
406 timer.Start(); 406 timer.Start();
407 for (int i = 0; i < kNumIterations; i++) { 407 for (int i = 0; i < kNumIterations; i++) {
408 StackFrameIterator frames(StackFrameIterator::kDontValidateFrames); 408 StackFrameIterator frames(StackFrameIterator::kDontValidateFrames,
409 Thread::Current(),
410 StackFrameIterator::kNoCrossThreadIteration);
409 StackFrame* frame = frames.NextFrame(); 411 StackFrame* frame = frames.NextFrame();
410 while (frame != NULL) { 412 while (frame != NULL) {
411 if (frame->IsStubFrame()) { 413 if (frame->IsStubFrame()) {
412 code = frame->LookupDartCode(); 414 code = frame->LookupDartCode();
413 EXPECT(code.function() == Function::null()); 415 EXPECT(code.function() == Function::null());
414 } else if (frame->IsDartFrame()) { 416 } else if (frame->IsDartFrame()) {
415 code = frame->LookupDartCode(); 417 code = frame->LookupDartCode();
416 EXPECT(code.function() != Function::null()); 418 EXPECT(code.function() != Function::null());
417 } 419 }
418 frame = frames.NextFrame(); 420 frame = frames.NextFrame();
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
723 int64_t elapsed_time = timer.TotalElapsedTime(); 725 int64_t elapsed_time = timer.TotalElapsedTime();
724 benchmark->set_score(elapsed_time); 726 benchmark->set_score(elapsed_time);
725 } 727 }
726 728
727 729
728 BENCHMARK_MEMORY(InitialRSS) { 730 BENCHMARK_MEMORY(InitialRSS) {
729 benchmark->set_score(OS::MaxRSS()); 731 benchmark->set_score(OS::MaxRSS());
730 } 732 }
731 733
732 } // namespace dart 734 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/lib/stacktrace.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698