Fix asserts in StackFrameIterator which were effectively disabled

runtime/vm/stack_frame.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_STACK_FRAME_H_
 #define RUNTIME_VM_STACK_FRAME_H_
 
 #include "vm/allocation.h"
 #include "vm/object.h"
 #include "vm/stub_code.h"
@@ skipping 194 matching lines @@
 // users of StackFrameIterator to ensure that the thread given is not running
 // concurrently.
 class StackFrameIterator : public ValueObject {
  public:
   static const bool kValidateFrames = true;
   static const bool kDontValidateFrames = false;
 
   // Iterators for iterating over all frames from the last ExitFrame to the
   // first EntryFrame.
   explicit StackFrameIterator(bool validate,
-                              Thread* thread = Thread::Current());
+                              Thread* thread,
+                              bool allow_iterating_other_thread);
   StackFrameIterator(uword last_fp,
                      bool validate,
-                     Thread* thread = Thread::Current());
+                     Thread* thread,
+                     bool allow_iterating_other_thread);
 
 #if !defined(TARGET_ARCH_DBC)
   // Iterator for iterating over all frames from the current frame (given by its
   // fp, sp, and pc) to the first EntryFrame.
   StackFrameIterator(uword fp,
                      uword sp,
                      uword pc,
                      bool validate,
-                     Thread* thread = Thread::Current());
+                     Thread* thread,
+                     bool allow_iterating_other_thread);
 #endif
 
   // Checks if a next frame exists.
   bool HasNextFrame() const { return frames_.fp_ != 0; }
 
   // Get next frame.
   StackFrame* NextFrame();
 
   bool validate() const { return validate_; }
 
@@ skipping 57 matching lines @@
 
 // Iterator for iterating over all dart frames (skips over exit frames,
 // entry frames and stub frames).
 // A DartFrameIterator can be initialized with an isolate other than the
 // current thread's isolate. Because this is generally a bad idea,
 // it is only allowed on Windows- where it is needed for the profiler.
 // It is the responsibility of users of DartFrameIterator to ensure that the
 // isolate given is not running concurrently on another thread.
 class DartFrameIterator : public ValueObject {
  public:
-  explicit DartFrameIterator(Thread* thread = Thread::Current())
-      : frames_(StackFrameIterator::kDontValidateFrames, thread) {}
-  explicit DartFrameIterator(uword last_fp, Thread* thread = Thread::Current())
-      : frames_(last_fp, StackFrameIterator::kDontValidateFrames, thread) {}
+  explicit DartFrameIterator(Thread* thread, bool allow_iterating_other_thread)
+      : frames_(StackFrameIterator::kDontValidateFrames,
+                thread,
+                allow_iterating_other_thread) {}
+  explicit DartFrameIterator(uword last_fp,
+                             Thread* thread,
+                             bool allow_iterating_other_thread)
+      : frames_(last_fp,
+                StackFrameIterator::kDontValidateFrames,
+                thread,
+                allow_iterating_other_thread) {}
 
 #if !defined(TARGET_ARCH_DBC)
   DartFrameIterator(uword fp,
                     uword sp,
                     uword pc,
-                    Thread* thread = Thread::Current())
-      : frames_(fp, sp, pc, StackFrameIterator::kDontValidateFrames, thread) {}
+                    Thread* thread,
+                    bool allow_iterating_other_thread)
+      : frames_(fp,
+                sp,
+                pc,
+                StackFrameIterator::kDontValidateFrames,
+                thread,
+                allow_iterating_other_thread) {}
 #endif
 
   // Get next dart frame.
   StackFrame* NextFrame() {
     StackFrame* frame = frames_.NextFrame();
     while (frame != NULL && !frame->IsDartFrame(frames_.validate())) {
       frame = frames_.NextFrame();
     }
     return frame;
   }
@@ skipping 77 matching lines @@
 
 
 DART_FORCE_INLINE static uword LocalVarAddress(uword fp, intptr_t index) {
   return fp + LocalVarIndex(0, index) * kWordSize;
 }
 
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_STACK_FRAME_H_