Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: runtime/vm/os_fuchsia.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)
Patch Set: remote two assertions which cannot be made Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(HOST_OS_FUCHSIA) 6 #if defined(HOST_OS_FUCHSIA)
7 7
8 #include "vm/os.h" 8 #include "vm/os.h"
9 9
10 #include <errno.h> 10 #include <errno.h>
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 // TODO(5411554): Allow overriding default code alignment for 139 // TODO(5411554): Allow overriding default code alignment for
140 // testing purposes. 140 // testing purposes.
141 // Flags::DebugIsInt("codealign", &alignment); 141 // Flags::DebugIsInt("codealign", &alignment);
142 ASSERT(Utils::IsPowerOfTwo(alignment)); 142 ASSERT(Utils::IsPowerOfTwo(alignment));
143 ASSERT(alignment >= kMinimumAlignment); 143 ASSERT(alignment >= kMinimumAlignment);
144 ASSERT(alignment <= OS::kMaxPreferredCodeAlignment); 144 ASSERT(alignment <= OS::kMaxPreferredCodeAlignment);
145 return alignment; 145 return alignment;
146 } 146 }
147 147
148 148
149 bool OS::AllowStackFrameIteratorFromAnotherThread() {
150 UNIMPLEMENTED();
151 return false;
152 }
153
154
155 int OS::NumberOfAvailableProcessors() { 149 int OS::NumberOfAvailableProcessors() {
156 return sysconf(_SC_NPROCESSORS_CONF); 150 return sysconf(_SC_NPROCESSORS_CONF);
157 } 151 }
158 152
159 153
160 uintptr_t OS::MaxRSS() { 154 uintptr_t OS::MaxRSS() {
161 mx_info_task_stats_t task_stats; 155 mx_info_task_stats_t task_stats;
162 mx_handle_t process = mx_process_self(); 156 mx_handle_t process = mx_process_self();
163 mx_status_t status = mx_object_get_info( 157 mx_status_t status = mx_object_get_info(
164 process, MX_INFO_TASK_STATS, &task_stats, sizeof(task_stats), NULL, NULL); 158 process, MX_INFO_TASK_STATS, &task_stats, sizeof(task_stats), NULL, NULL);
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 } 309 }
316 310
317 311
318 void OS::Exit(int code) { 312 void OS::Exit(int code) {
319 UNIMPLEMENTED(); 313 UNIMPLEMENTED();
320 } 314 }
321 315
322 } // namespace dart 316 } // namespace dart
323 317
324 #endif // defined(HOST_OS_FUCHSIA) 318 #endif // defined(HOST_OS_FUCHSIA)
OLDNEW
« runtime/vm/debugger.cc ('K') | « runtime/vm/os_android.cc ('k') | runtime/vm/os_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698