Chromium Code Reviews
Help | Chromium Project | Sign in
(243)

Issue 2845031: Reland r50296 which removes some uses of CookieMonster on the UI thread. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by willchan OOO until 04-22-15
Modified:
3 years, 10 months ago
Reviewers:
rdsmith
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, PaweĊ‚ Hajdan Jr., darin-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Reland r50296 which removes some uses of CookieMonster on the UI thread. Removes the addition of NonThreadSafe and DCHECKs to CookieMonster. BUG=44083 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51164

Patch Set 1 #

Patch Set 2 : Get rid of spurious whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -128 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 5 chunks +114 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_api.h View 4 chunks +65 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_api.cc View 7 chunks +178 lines, -74 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_helpers.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_cookies_helpers.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_data_deleter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_data_deleter.cc View 1 chunk +18 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_function.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 1 6 chunks +50 lines, -12 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
willchan OOO until 04-22-15
4 years, 9 months ago (2010-06-29 16:54:51 UTC) #1
rdsmith
4 years, 9 months ago (2010-06-29 19:51:46 UTC) #2
Will: I don't consider myself competent to evaluate all the changes in this CL,
but I do consider myself competent to verify that a) This should solve the
problem for which you reverted 50296, and b) the only changes between this and
50296 are to restore the CookieMonster to all of its thread safe glory (and
grief :-}).  And I think that's good enough for this review.  So: LGTM.  

(Though I'll call out that I'm seeing presubmit errors in a few files other than
cookie_monster.{h,cc} when I patch this CL into my branch, which seems weird--I
didn't see any differences between those files and your original.  So I'll call
this out just FYI; it might be an artifact of how I patched my branch, somehow.)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted