Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 284503002: Simplify DoubleRegister for the ia32 port. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Simplify DoubleRegister for the ia32 port. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21284

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -84 lines) Patch
M src/ia32/assembler-ia32.h View 1 2 chunks +27 lines, -52 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 7 months ago (2014-05-12 14:15:37 UTC) #1
Jakob Kummerow
LGTM. I think we can clean up even further, but feel free to punt on ...
6 years, 7 months ago (2014-05-12 14:23:33 UTC) #2
Yang
On 2014/05/12 14:23:33, Jakob wrote: > LGTM. I think we can clean up even further, ...
6 years, 7 months ago (2014-05-13 08:57:54 UTC) #3
Yang
6 years, 7 months ago (2014-05-13 09:05:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698