Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/ui/cocoa/l10n_util.h

Issue 2845003003: [Mac] Reverse bookmark buttons and menus in RTL (take 2) (Closed)
Patch Set: Go back to hardcoding image y offset Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_L10N_UTIL_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_L10N_UTIL_H_
6 #define CHROME_BROWSER_UI_COCOA_L10N_UTIL_H_ 6 #define CHROME_BROWSER_UI_COCOA_L10N_UTIL_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // If ExperimentalMacRTL becomes the default, this function can be replaced with 45 // If ExperimentalMacRTL becomes the default, this function can be replaced with
46 // uses of base::i18n::IsRTL(). 46 // uses of base::i18n::IsRTL().
47 bool ShouldDoExperimentalRTLLayout(); 47 bool ShouldDoExperimentalRTLLayout();
48 48
49 // Returns true if ShouldDoExperimentalRTLLayout() is true and the OS is 49 // Returns true if ShouldDoExperimentalRTLLayout() is true and the OS is
50 // 10.12 or above. macOS 10.12 is the first OS where the native stoplight 50 // 10.12 or above. macOS 10.12 is the first OS where the native stoplight
51 // buttons are reversed in RTL, so manually reversing them in previous 51 // buttons are reversed in RTL, so manually reversing them in previous
52 // OSes would make Chrome stick out. 52 // OSes would make Chrome stick out.
53 bool ShouldFlipWindowControlsInRTL(); 53 bool ShouldFlipWindowControlsInRTL();
54 54
55 // TODO(lgrey): Remove these when all builds are on 10.12 SDK.
shrike 2017/05/03 17:35:55 Can you add something like a check for min deploym
lgrey 2017/05/03 21:32:48 Done
56
57 // Returns NSImageLeading when available (10.12+), otherwise
58 // NSImageLeft for LTR and NSImageRight in RTL.
59 NSCellImagePosition LeadingCellImagePosition();
60 // Returns NSImageTrailing when available (10.12+), otherwise
61 // NSImageRight for LTR and NSImageLeft in RTL.
62 NSCellImagePosition TrailingCellImagePosition();
63
55 // Returns an autoreleased image containing |image| flipped 64 // Returns an autoreleased image containing |image| flipped
56 // across the x axis. 65 // across the x axis.
57 NSImage* FlippedImage(NSImage* image); 66 NSImage* FlippedImage(NSImage* image);
58 67
59 } // namespace cocoa_l10n_util 68 } // namespace cocoa_l10n_util
60 69
61 #endif // CHROME_BROWSER_UI_COCOA_L10N_UTIL_H_ 70 #endif // CHROME_BROWSER_UI_COCOA_L10N_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698