[Mac] Reverse bookmark buttons and menus in RTL (take 2)

chrome/browser/ui/cocoa/gradient_button_cell.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

[Elly Fong-Jones, 2017/05/03 17:03:14]

this might be a dumb question but now that we do MD top chrome on mac do we ever
actually draw gradients? if not can we get rid of this code?

[lgrey, 2017/05/03 21:32:48]

I'd like to but Find Bar still uses it. We discussed moving it over to MD as a
yak shave for this, but came down on the no side.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/gradient_button_cell.h"
 
 #include <cmath>
 
 #include "base/logging.h"
 #import "base/mac/scoped_nsobject.h"
 #import "chrome/browser/themes/theme_properties.h"
@@ skipping 471 matching lines @@
                  ThemeProperties::COLOR_TOOLBAR_BUTTON_STROKE_INACTIVE) :
         [NSColor colorWithCalibratedWhite:0.0
                                     alpha:0.3 * outerStrokeAlphaMult_];
   }
   [strokeColor setStroke];
 
   [innerPath setLineWidth:1];
   [innerPath stroke];
 }
 
+- (CGFloat)insetInView:(NSView*)controlView {
+  if (!controlView)

[Elly Fong-Jones, 2017/05/03 17:03:14]

can that happen?

[lgrey, 2017/05/03 21:32:48]

I think this was vestigial from a class method calling it. Removed.

+    return [[NSScreen mainScreen] convertRectToBacking:NSMakeRect(0, 0, 1, 1)]
+        .size.width;
+  return [controlView cr_lineWidth];
+}
+
 // TODO(viettrungluu): clean this up.
 // (Private)
 - (void)getDrawParamsForFrame:(NSRect)cellFrame
                        inView:(NSView*)controlView
                    innerFrame:(NSRect*)returnInnerFrame
                     innerPath:(NSBezierPath**)returnInnerPath
                      clipPath:(NSBezierPath**)returnClipPath {
-  const CGFloat kLineWidth = [controlView cr_lineWidth];
-  const CGFloat kHalfLineWidth = kLineWidth / 2.0;
+  const CGFloat lineWidth = [self insetInView:controlView];
+  const CGFloat halfLineWidth = lineWidth / 2.0;
 
   NSRect drawFrame = NSZeroRect;
   NSRect innerFrame = NSZeroRect;
   CGFloat cornerRadius = 2;
   if (![self isMaterialDesignButtonType]) {
-    drawFrame = NSInsetRect(cellFrame, 1.5 * kLineWidth, 1.5 * kLineWidth);
-    innerFrame = NSInsetRect(cellFrame, kLineWidth, kLineWidth);
+    drawFrame = NSInsetRect(cellFrame, 1.5 * lineWidth, 1.5 * lineWidth);
+    innerFrame = NSInsetRect(cellFrame, lineWidth, lineWidth);
     cornerRadius = 3;
   } else {
     drawFrame = cellFrame;
     // Hover and click paths are always 20pt tall, regardless of the button's
     // height.
     drawFrame.size.height = 20;
-    innerFrame = NSInsetRect(drawFrame, kLineWidth, kLineWidth);
+    innerFrame = NSInsetRect(drawFrame, lineWidth, lineWidth);
   }
 
   ButtonType type = [[(NSControl*)controlView cell] tag];
   switch (type) {
     case kMiddleButtonType:
       drawFrame.size.width += 20;
       innerFrame.size.width += 2;
       // Fallthrough
     case kRightButtonType:
       drawFrame.origin.x -= 20;
@@ skipping 17 matching lines @@
     drawFrame.origin.y +=
         [self hoverBackgroundVerticalOffsetInControlView:controlView];
 
     if ([self tag] == kMaterialMenuButtonTypeWithLimitedClickFeedback) {
       *returnInnerPath = [NSBezierPath bezierPathWithRect:drawFrame];
     } else {
       *returnInnerPath = [NSBezierPath bezierPathWithRoundedRect:drawFrame
                                                          xRadius:cornerRadius
                                                          yRadius:cornerRadius];
     }
-    [*returnInnerPath setLineWidth:kLineWidth];
+    [*returnInnerPath setLineWidth:lineWidth];
   }
   if (returnClipPath) {
     DCHECK(*returnClipPath == nil);
     NSRect clipPathRect =
-        NSInsetRect(drawFrame, -kHalfLineWidth, -kHalfLineWidth);
-    *returnClipPath = [NSBezierPath
-        bezierPathWithRoundedRect:clipPathRect
-                          xRadius:cornerRadius + kHalfLineWidth
-                          yRadius:cornerRadius + kHalfLineWidth];
+        NSInsetRect(drawFrame, -halfLineWidth, -halfLineWidth);
+    *returnClipPath =
+        [NSBezierPath bezierPathWithRoundedRect:clipPathRect
+                                        xRadius:cornerRadius + halfLineWidth
+                                        yRadius:cornerRadius + halfLineWidth];
   }
 }
 
 // TODO(viettrungluu): clean this up.
 - (void)drawWithFrame:(NSRect)cellFrame inView:(NSView*)controlView {
   NSRect innerFrame;
   NSBezierPath* innerPath = nil;
   [self getDrawParamsForFrame:cellFrame
                        inView:controlView
                    innerFrame:&innerFrame
@@ skipping 163 matching lines @@
   NSDivideRect(cellFrame, &gradientPart, &solidPart, gradientWidth, NSMaxXEdge);
 
   // Draw non-gradient part without transparency layer, as light text on a dark
   // background looks bad with a gradient layer.
   NSPoint textOffset = NSZeroPoint;
   {
     gfx::ScopedNSGraphicsContextSaveGState scopedGState;
     if (shouldClipTheTitle)
       [NSBezierPath clipRect:solidPart];
 
-    CGFloat textLeft = [self textStartXOffset];
 
     // For some reason, the height of cellFrame as passed in is totally bogus.
     // For vertical centering purposes, we need the bounds of the containing
     // view.
     NSRect buttonFrame = [[self controlView] frame];
 
     // Call the vertical offset to match native NSButtonCell's version.
-    textOffset = NSMakePoint(textLeft,
-                             (NSHeight(buttonFrame) - size.height) / 2 +
-                             [self verticalTextOffset]);
+    textOffset = NSMakePoint(
+        NSMinX(cellFrame),
+        (NSHeight(buttonFrame) - size.height) / 2 + [self verticalTextOffset]);
     // WIth Material Design we want an ellipsis if the title is too long to fit,
     // so have to use drawInRect: instead of drawAtPoint:.
     if (isModeMaterial) {
-      NSRect textBounds = NSMakeRect(textOffset.x,
-                                     textOffset.y,
-                                     NSWidth(buttonFrame) - textOffset.x,
-                                     NSHeight(buttonFrame));
-      [title drawInRect:textBounds];
+      NSRect textFrame = NSMakeRect(textOffset.x, textOffset.y,
+                                    NSWidth(cellFrame), NSHeight(buttonFrame));
+      [title drawInRect:textFrame];
     } else {
       [title drawAtPoint:textOffset];
     }
   }
 
   if (!shouldClipTheTitle)
     return cellFrame;
 
   // Draw the gradient part with a transparency layer. This makes the text look
   // suboptimal, but since it fades out, that's ok.
@@ skipping 70 matching lines @@
                              options:options
                                owner:self
                             userInfo:nil]);
   if (isMouseInside_ != mouseInView) {
     [self setMouseInside:mouseInView animate:NO];
     [controlView setNeedsDisplay:YES];
   }
 }
 
 @end