Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chromeos/components/tether/connect_tethering_operation_unittest.cc

Issue 2844973002: [CrOS Tether] Create TetherHostResponseRecorder, which records ConnectTetheringResponses and Tether… (Closed)
Patch Set: Removed file that didn't belong in this CL, alphabetized forward declarations. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/components/tether/connect_tethering_operation_unittest.cc
diff --git a/chromeos/components/tether/connect_tethering_operation_unittest.cc b/chromeos/components/tether/connect_tethering_operation_unittest.cc
index 85f09ebfe3d0217bd9e36668ad67aa55a215838f..cb736b23c36f2740be246a5c57d25f7d95ca33f9 100644
--- a/chromeos/components/tether/connect_tethering_operation_unittest.cc
+++ b/chromeos/components/tether/connect_tethering_operation_unittest.cc
@@ -11,7 +11,7 @@
#include "chromeos/components/tether/ble_constants.h"
#include "chromeos/components/tether/fake_ble_connection_manager.h"
#include "chromeos/components/tether/message_wrapper.h"
-#include "chromeos/components/tether/mock_host_scan_device_prioritizer.h"
+#include "chromeos/components/tether/mock_tether_host_response_recorder.h"
#include "chromeos/components/tether/proto/tether.pb.h"
#include "components/cryptauth/remote_device_test_util.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -111,13 +111,13 @@ class ConnectTetheringOperationTest : public testing::Test {
void SetUp() override {
fake_ble_connection_manager_ = base::MakeUnique<FakeBleConnectionManager>();
- mock_host_scan_device_prioritizer_ =
- base::MakeUnique<StrictMock<MockHostScanDevicePrioritizer>>();
+ mock_tether_host_response_recorder_ =
+ base::MakeUnique<StrictMock<MockTetherHostResponseRecorder>>();
test_observer_ = base::WrapUnique(new TestObserver());
operation_ = base::WrapUnique(new ConnectTetheringOperation(
test_device_, fake_ble_connection_manager_.get(),
- mock_host_scan_device_prioritizer_.get()));
+ mock_tether_host_response_recorder_.get()));
operation_->AddObserver(test_observer_.get());
operation_->Initialize();
}
@@ -170,8 +170,8 @@ class ConnectTetheringOperationTest : public testing::Test {
const cryptauth::RemoteDevice test_device_;
std::unique_ptr<FakeBleConnectionManager> fake_ble_connection_manager_;
- std::unique_ptr<StrictMock<MockHostScanDevicePrioritizer>>
- mock_host_scan_device_prioritizer_;
+ std::unique_ptr<StrictMock<MockTetherHostResponseRecorder>>
+ mock_tether_host_response_recorder_;
std::unique_ptr<TestObserver> test_observer_;
std::unique_ptr<ConnectTetheringOperation> operation_;
@@ -180,7 +180,7 @@ class ConnectTetheringOperationTest : public testing::Test {
};
TEST_F(ConnectTetheringOperationTest, TestOperation_SuccessButInvalidResponse) {
- EXPECT_CALL(*mock_host_scan_device_prioritizer_,
+ EXPECT_CALL(*mock_tether_host_response_recorder_,
RecordSuccessfulConnectTetheringResponse(_))
.Times(0);
@@ -192,7 +192,7 @@ TEST_F(ConnectTetheringOperationTest, TestOperation_SuccessButInvalidResponse) {
}
TEST_F(ConnectTetheringOperationTest, TestOperation_SuccessWithValidResponse) {
- EXPECT_CALL(*mock_host_scan_device_prioritizer_,
+ EXPECT_CALL(*mock_tether_host_response_recorder_,
RecordSuccessfulConnectTetheringResponse(test_device_));
SimulateDeviceAuthenticationAndVerifyMessageSent();
@@ -203,7 +203,7 @@ TEST_F(ConnectTetheringOperationTest, TestOperation_SuccessWithValidResponse) {
}
TEST_F(ConnectTetheringOperationTest, TestOperation_UnknownError) {
- EXPECT_CALL(*mock_host_scan_device_prioritizer_,
+ EXPECT_CALL(*mock_tether_host_response_recorder_,
RecordSuccessfulConnectTetheringResponse(_))
.Times(0);
@@ -215,7 +215,7 @@ TEST_F(ConnectTetheringOperationTest, TestOperation_UnknownError) {
}
TEST_F(ConnectTetheringOperationTest, TestOperation_ProvisioningFailed) {
- EXPECT_CALL(*mock_host_scan_device_prioritizer_,
+ EXPECT_CALL(*mock_tether_host_response_recorder_,
RecordSuccessfulConnectTetheringResponse(_))
.Times(0);
@@ -227,7 +227,7 @@ TEST_F(ConnectTetheringOperationTest, TestOperation_ProvisioningFailed) {
}
TEST_F(ConnectTetheringOperationTest, TestCannotConnect) {
- EXPECT_CALL(*mock_host_scan_device_prioritizer_,
+ EXPECT_CALL(*mock_tether_host_response_recorder_,
RecordSuccessfulConnectTetheringResponse(_))
.Times(0);

Powered by Google App Engine
This is Rietveld 408576698