[CrOS Tether] Create TetherHostResponseRecorder, which records ConnectTetheringResponses and Tether…

chromeos/components/tether/host_scanner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/components/tether/host_scanner.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "chromeos/components/tether/device_id_tether_network_guid_map.h"
@@ skipping 18 matching lines @@
 int32_t ForceBetweenZeroAndOneHundred(int32_t value) {
   return std::min(std::max(value, 0), 100);
 }
 
 }  // namespace
 
 HostScanner::HostScanner(
     TetherHostFetcher* tether_host_fetcher,
     BleConnectionManager* connection_manager,
     HostScanDevicePrioritizer* host_scan_device_prioritizer,
+    TetherHostResponseRecorder* tether_host_response_recorder,
     NetworkStateHandler* network_state_handler,
     NotificationPresenter* notification_presenter,
     DeviceIdTetherNetworkGuidMap* device_id_tether_network_guid_map)
     : tether_host_fetcher_(tether_host_fetcher),
       connection_manager_(connection_manager),
       host_scan_device_prioritizer_(host_scan_device_prioritizer),
+      tether_host_response_recorder_(tether_host_response_recorder),
       network_state_handler_(network_state_handler),
       notification_presenter_(notification_presenter),
       device_id_tether_network_guid_map_(device_id_tether_network_guid_map),
       is_fetching_hosts_(false),
       weak_ptr_factory_(this) {}
 
 HostScanner::~HostScanner() {}
 
 void HostScanner::StartScan() {
   if (host_scanner_operation_) {
@@ skipping 13 matching lines @@
 
 bool HostScanner::IsScanActive() {
   return is_fetching_hosts_ || host_scanner_operation_;
 }
 
 void HostScanner::OnTetherHostsFetched(
     const cryptauth::RemoteDeviceList& tether_hosts) {
   is_fetching_hosts_ = false;
 
   host_scanner_operation_ = HostScannerOperation::Factory::NewInstance(
-      tether_hosts, connection_manager_, host_scan_device_prioritizer_);
+      tether_hosts, connection_manager_, host_scan_device_prioritizer_,
+      tether_host_response_recorder_);
   host_scanner_operation_->AddObserver(this);
   host_scanner_operation_->Initialize();
 }
 
 void HostScanner::OnTetherAvailabilityResponse(
     std::vector<HostScannerOperation::ScannedDeviceInfo>&
         scanned_device_list_so_far,
     bool is_final_scan_result) {
   most_recent_scan_results_ = scanned_device_list_so_far;
 
@@ skipping 27 matching lines @@
               : 100;
 
       network_state_handler_->AddTetherNetworkState(
           device_id_tether_network_guid_map_->GetTetherNetworkGuidForDeviceId(
               remote_device.GetDeviceId()),
           remote_device.name, carrier, battery_percentage, signal_strength);
     }
 
     if (scanned_device_list_so_far.size() == 1) {
       notification_presenter_->NotifyPotentialHotspotNearby(
           scanned_device_list_so_far.at(0).remote_device);

[Ryan Hansberry, 2017/04/27 17:45:54]

How do you plan to inform the UI layer that the Connect button should or should
not show the dialog? (If you plan to do so by passing an argument to
NotificationPresenter, you should do so in this CL)

[Kyle Horimoto, 2017/04/27 17:51:42]

I'm adding a new HasConnectedToHost network property to the network stack (as I
did with battery percentage, carrier, and signal strength). When
NetworkConnect::ConnectToNetworkId() is called, NetworkConnect will grab the
corresponding NetworkState from NetworkStateHandler and check whether that
device has connected already. If it has not yet connected, it will bring up the
settings page instead of starting the connection.

[Ryan Hansberry, 2017/04/27 18:08:25]

Got it. I assume that will be passed as a new argument of AddTetherNetworkState,
so please add a TODO above the invocation of it in this file indicating that
that will be done.

[Kyle Horimoto, 2017/04/27 18:10:55]

Done.

     } else {
       notification_presenter_->NotifyMultiplePotentialHotspotsNearby();
     }
   }
 
   if (is_final_scan_result) {
     // If the final scan result has been received, the operation is finished.
     // Delete it.
     host_scanner_operation_->RemoveObserver(this);
     host_scanner_operation_.reset();
   }
 }
 
 }  // namespace tether
 
 }  // namespace chromeos