chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc - Issue 2844963003: Introduce extensions::CreateUrlCollectionFromForm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

Issue 2844963003: Introduce extensions::CreateUrlCollectionFromForm (Closed)

Patch Set: Revert One-Liner Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

index 380e99ac88bcc5d7da218234202f7d2dc9ec6f4e..b5a22d8691241e90e2b6fa667d05d7bba23c8043 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

@@ -74,8 +74,7 @@ void PasswordsPrivateEventRouter::OnPlaintextPasswordFetched(

const std::string& username,

const std::string& plaintext_password) {

api::passwords_private::PlaintextPasswordEventParameters params;

- // TODO(crbug.com/715866): use origins and URLs more consistently.

- params.login_pair.urls.origin = GURL(origin_url).GetOrigin().spec();

+ params.login_pair.urls.origin = origin_url;

params.login_pair.username = username;

params.plaintext_password = plaintext_password;