Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h

Issue 2844963003: Introduce extensions::CreateUrlCollectionFromForm (Closed)
Patch Set: Revert One-Liner Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
index 15cfac7d522c5e156025b2f1773eaed5b998e6e8..4371b3ad06040f255d49ab29e12ecc4eab44835f 100644
--- a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
@@ -52,8 +52,8 @@ class PasswordsPrivateDelegate : public KeyedService {
// Removes the saved password entry corresponding to |origin_url| and
// |username|.
- // |origin_url| The human-readable origin for the URL where the password is
- // used/ should be obtained using GetHumanReadableOrigin().
+ // |origin_url| The origin for the URL where the password is used; should be
+ // obtained using CreateUrlCollectionFromForm().origin.
// |username| The username used in conjunction with the saved password.
virtual void RemoveSavedPassword(
const std::string& origin_url, const std::string& username) = 0;
@@ -61,13 +61,13 @@ class PasswordsPrivateDelegate : public KeyedService {
// Removes the saved password exception entry corresponding to
// |exception_url|.
// |exception_url| The URL corresponding to the exception to remove; should
- // be obtained using GetHumanReadableOrigin().
+ // be obtained using CreateUrlCollectionFromForm().origin.
virtual void RemovePasswordException(const std::string& exception_url) = 0;
// Requests the plain text password for entry corresponding to |origin_url|
// and |username|.
- // |origin_url| The human-readable origin for the URL where the password is
- // used; should be obtained using GetHumanReadableOrigin().
+ // |origin_url| The origin for the URL where the password is used; should be
+ // obtained using CreateUrlCollectionFromForm().origin.
// |username| The username used in conjunction with the saved password.
// |native_window| The Chrome host window; will be used to show an OS-level
// authentication dialog if necessary.
« no previous file with comments | « chrome/browser/extensions/BUILD.gn ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698