Fix policy_component shared_library link without configuration_policy

Fix policy_component shared_library link without configuration_policy

It should depend on url_matcher as url_blacklist_manager uses it.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270410

[Joao da Silva, 2014-05-12 11:51:09]

Thanks for fixing. Just one comment to fix, see inline.

https://codereview.chromium.org/284493002/diff/1/components/policy/policy_com...
File components/policy/policy_common.gypi (right):

https://codereview.chromium.org/284493002/diff/1/components/policy/policy_com...
components/policy/policy_common.gypi:17: 'core/common/policy_pref_names.h',
If the pref names are needed then they should be included below (see next
comment)

https://codereview.chromium.org/284493002/diff/1/components/policy/policy_com...
components/policy/policy_common.gypi:211: 'core/common/policy_service_stub.h',
This is where policy_pref_names.* should go, if it needs to be included when
configuration_policy==0.

[Jiang Jiang, 2014-05-12 12:02:05]

On 2014/05/12 11:51:09, Joao da Silva wrote:
> Thanks for fixing. Just one comment to fix, see inline.
> 
>
https://codereview.chromium.org/284493002/diff/1/components/policy/policy_com...
> File components/policy/policy_common.gypi (right):
> 
>
https://codereview.chromium.org/284493002/diff/1/components/policy/policy_com...
> components/policy/policy_common.gypi:17: 'core/common/policy_pref_names.h',
> If the pref names are needed then they should be included below (see next
> comment)
> 
>
https://codereview.chromium.org/284493002/diff/1/components/policy/policy_com...
> components/policy/policy_common.gypi:211: 'core/common/policy_service_stub.h',
> This is where policy_pref_names.* should go, if it needs to be included when
> configuration_policy==0.

Thanks for the quick review! Addressed in patch set 2.

[Joao da Silva, 2014-05-12 12:04:04]

lgtm

You need a higher-level owner to approve this change. I'd suggest adding jochen@
as a reviewer for that.

[Jiang Jiang, 2014-05-12 12:07:06]

jochen, can you please take a look at the chrome/ part of this change?

[jochen (gone - plz use gerrit), 2014-05-14 08:34:48]

lgtm

[Jiang Jiang, 2014-05-14 08:42:20]

The CQ bit was checked by jiangj@opera.com

[commit-bot: I haz the power, 2014-05-14 08:42:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jiangj@opera.com/284493002/20001

[commit-bot: I haz the power, 2014-05-14 14:00:03]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-14 15:37:04]

Change committed as 270410