Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2844903002: Extend file-system abstraction with a couple methods, remove context (Closed)

Created:
3 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extend file-system abstraction with a couple methods, remove context. New methods: - exists: I'll be using it for input validation among other things - lastModified: I'll be using this on some utilities to support the incremental API. BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/99ab24f628b23f248582874a6987883ab76c3195 Committed: https://github.com/dart-lang/sdk/commit/102de9e476bcd2b17f35604a7a3e442b28e14194 Committed: https://github.com/dart-lang/sdk/commit/f8fbff73225729f720e951253400ce6adf2aa083

Patch Set 1 : v3 #

Total comments: 1

Patch Set 2 : fix remaining tests #

Patch Set 3 : fix test in windows bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -54 lines) Patch
M pkg/front_end/lib/file_system.dart View 4 chunks +9 lines, -10 lines 0 comments Download
M pkg/front_end/lib/kernel_generator.dart View 4 chunks +7 lines, -10 lines 0 comments Download
M pkg/front_end/lib/memory_file_system.dart View 5 chunks +27 lines, -8 lines 0 comments Download
M pkg/front_end/lib/physical_file_system.dart View 3 chunks +12 lines, -5 lines 0 comments Download
M pkg/front_end/test/dependency_grapher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 1 2 chunks +1 line, -2 lines 0 comments Download
M pkg/front_end/test/incremental_resolved_ast_generator_test.dart View 1 2 chunks +1 line, -2 lines 0 comments Download
M pkg/front_end/test/memory_file_system_test.dart View 9 chunks +38 lines, -14 lines 0 comments Download
M pkg/front_end/test/physical_file_system_test.dart View 1 2 2 chunks +66 lines, -0 lines 0 comments Download
M pkg/front_end/test/src/base/processed_options_test.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2844903002/diff/40001/pkg/front_end/lib/file_system.dart File pkg/front_end/lib/file_system.dart (left): https://codereview.chromium.org/2844903002/diff/40001/pkg/front_end/lib/file_system.dart#oldcode24 pkg/front_end/lib/file_system.dart:24: path.Context get context; I can split this change if ...
3 years, 8 months ago (2017-04-27 00:08:50 UTC) #5
Paul Berry
lgtm
3 years, 7 months ago (2017-04-27 13:12:18 UTC) #6
Siggi Cherem (dart-lang)
Committed patchset #1 (id:40001) manually as 99ab24f628b23f248582874a6987883ab76c3195 (presubmit successful).
3 years, 7 months ago (2017-04-27 21:01:17 UTC) #8
Siggi Cherem (dart-lang)
Committed patchset #2 (id:60001) manually as 102de9e476bcd2b17f35604a7a3e442b28e14194 (presubmit successful).
3 years, 7 months ago (2017-04-27 22:05:17 UTC) #10
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-04-28 22:57:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
f8fbff73225729f720e951253400ce6adf2aa083 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698