Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2844883005: Use the dart:io Platform.resolvedExecutable API to locate the Dart SDK. (Closed)

Created:
3 years, 7 months ago by devoncarew
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -16 lines) Patch
M pkg/analyzer/lib/src/lint/analysis.dart View 2 chunks +3 lines, -7 lines 0 comments Download
A pkg/analyzer/lib/src/util/sdk.dart View 1 chunk +32 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
devoncarew
Use the dart:io Platform.resolvedExecutable to locate the Dart SDK. This is a fairly reliable mechanism ...
3 years, 7 months ago (2017-04-27 03:54:52 UTC) #2
pquitslund
LGTM. Should we deprecate cli_utils?
3 years, 7 months ago (2017-04-27 13:27:23 UTC) #3
danrubel
LGTM
3 years, 7 months ago (2017-04-27 13:36:42 UTC) #4
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-04-27 16:10:02 UTC) #5
devoncarew
> Should we deprecate cli_utils? That would be my sense - now that we have ...
3 years, 7 months ago (2017-04-27 16:27:45 UTC) #6
devoncarew
3 years, 7 months ago (2017-04-27 16:29:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66ac96c4a6050993f589d4827119252cf89eb972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698