Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: third_party/WebKit/LayoutTests/PRESUBMIT.py

Issue 2844803005: Add a doc in the presubmit script checking if layout tests use eventSender (Closed)
Patch Set: comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/PRESUBMIT.py
diff --git a/third_party/WebKit/LayoutTests/PRESUBMIT.py b/third_party/WebKit/LayoutTests/PRESUBMIT.py
index ca7b4f986f0f2f6355e4740ab46787a44503aa97..39107fac85f4f1108e9878d0a735d238abf92804 100644
--- a/third_party/WebKit/LayoutTests/PRESUBMIT.py
+++ b/third_party/WebKit/LayoutTests/PRESUBMIT.py
@@ -98,8 +98,9 @@ def _CheckFilesUsingEventSender(input_api, output_api):
for line_num, line in f.ChangedContents():
if any(action in line for action in actions):
results.append(output_api.PresubmitError(
- 'Files that still use eventSender: %s:%d %s, please use chrome.gpuBenchmarking.pointerActionSequence instead.' %
- (f.LocalPath(), line_num, line)))
+ 'Files that still use eventSender, please use chrome.gpuBenchmarking.pointerActionSequence instead: ' +
dtapuska 2017/04/28 21:13:17 Not sure this is a complete sentence anymore. Perh
lanwei 2017/05/01 15:53:10 Done.
+ '(see https://crbug.com/711340 and http://goo.gl/BND75q)\n' +
+ ' %s:%d %s ' % (f.LocalPath(), line_num, line)))
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698