[Cronet] Make metrics reporting happen after terminal callbacks.

components/cronet/android/cronet_url_request_adapter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_ADAPTER_H_
 #define COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_ADAPTER_H_
 
 #include <jni.h>
 
 #include <memory>
 #include <string>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/callback.h"
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "net/base/request_priority.h"
 #include "net/url_request/url_request.h"
 #include "url/gurl.h"
 
 namespace net {
 class HttpRequestHeaders;
 class SSLCertRequestInfo;
 class SSLInfo;
 class UploadDataStream;
@@ skipping 42 matching lines @@
                             const base::android::JavaParamRef<jobject>& jcaller,
                             const base::android::JavaParamRef<jstring>& jname,
                             const base::android::JavaParamRef<jstring>& jvalue);
 
   // Adds a request body to the request before it starts.
   void SetUpload(std::unique_ptr<net::UploadDataStream> upload);
 
   // Starts the request.
   void Start(JNIEnv* env, const base::android::JavaParamRef<jobject>& jcaller);
 
-  void GetStatus(
-      JNIEnv* env,
-      const base::android::JavaParamRef<jobject>& jcaller,
-      const base::android::JavaParamRef<jobject>& jstatus_listener) const;
+  void GetStatus(JNIEnv* env,
+                 const base::android::JavaParamRef<jobject>& jcaller,
+                 const base::android::JavaParamRef<jobject>& jstatus_listener);
 
   // Follows redirect.
   void FollowDeferredRedirect(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& jcaller);
 
   // Reads more data.
   jboolean ReadData(JNIEnv* env,
                     const base::android::JavaParamRef<jobject>& jcaller,
                     const base::android::JavaParamRef<jobject>& jbyte_buffer,
                     jint jposition,
                     jint jcapacity);
 
   // Releases all resources for the request and deletes the object itself.
-  // |jsend_on_canceled| indicates if Java onCanceled callback should be
-  // issued to indicate when no more callbacks will be issued.
   void Destroy(JNIEnv* env,
-               const base::android::JavaParamRef<jobject>& jcaller,
-               jboolean jsend_on_canceled);
+               const base::android::JavaParamRef<jobject>& jcaller);
+
+  void Cancel(JNIEnv* env, const base::android::JavaParamRef<jobject>& jcaller);
 
   // net::URLRequest::Delegate implementations:
 
   void OnReceivedRedirect(net::URLRequest* request,
                           const net::RedirectInfo& redirect_info,
                           bool* defer_redirect) override;
   void OnCertificateRequested(
       net::URLRequest* request,
       net::SSLCertRequestInfo* cert_request_info) override;
   void OnSSLCertificateError(net::URLRequest* request,
                              const net::SSLInfo& ssl_info,
                              bool fatal) override;
   void OnResponseStarted(net::URLRequest* request, int net_error) override;
   void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
 
  private:
   friend class TestUtil;
 
   void StartOnNetworkThread();
   void GetStatusOnNetworkThread(
       const base::android::ScopedJavaGlobalRef<jobject>& jstatus_listener_ref)
       const;
   // Gets response headers on network thread.
   base::android::ScopedJavaLocalRef<jobjectArray> GetResponseHeaders(
       JNIEnv* env);
   void FollowDeferredRedirectOnNetworkThread();
   void ReadDataOnNetworkThread(
       scoped_refptr<IOBufferWithByteBuffer> read_buffer,
       int buffer_size);
-  void DestroyOnNetworkThread(bool send_on_canceled);
+  void DestroyOnNetworkThread();
+  void CancelOnNetworkThread();
 
   // Report error and cancel request_adapter.
   void ReportError(net::URLRequest* request, int net_error);
   // Reports metrics collected to the Java layer
   void MaybeReportMetrics(JNIEnv* env) const;
 
   CronetURLRequestContextAdapter* context_;
 
   // Java object that owns this CronetURLRequestContextAdapter.
   base::android::ScopedJavaGlobalRef<jobject> owner_;
 
   const GURL initial_url_;
   const net::RequestPriority initial_priority_;
   std::string initial_method_;
   int load_flags_;
   net::HttpRequestHeaders initial_request_headers_;
   std::unique_ptr<net::UploadDataStream> upload_;
 
   scoped_refptr<IOBufferWithByteBuffer> read_buffer_;
   std::unique_ptr<net::URLRequest> url_request_;
 
   // Whether detailed metrics should be collected and reported to Java for this
   // request.
   const bool enable_metrics_;
 
+  // This is needed because Native code can initiate destruction of |this| while
+  // there are posted tasks from Java yet to be run on the network task runner.
+  base::WeakPtrFactory<CronetURLRequestAdapter> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(CronetURLRequestAdapter);
 };
 
 }  // namespace cronet
 
 #endif  // COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_ADAPTER_H_