Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 2844663003: Fix some issues with options handling (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M pkg/analyzer/lib/src/context/builder.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
When the command-line analyzer is passed a file, the code was asking to create a ...
3 years, 8 months ago (2017-04-26 18:15:59 UTC) #2
danrubel
LGTM
3 years, 7 months ago (2017-04-27 14:27:44 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-04-27 17:22:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
511a06ee00eac7edb0d3dfcb5bf0c8d8146e3790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698