third_party/WebKit/Source/core/page/AutoscrollController.cpp - Issue 2844593002: Protect against lifecycle updates that delete a layout object for autoscroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/AutoscrollController.cpp

Issue 2844593002: Protect against lifecycle updates that delete a layout object for autoscroll (Closed)

Patch Set: none Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/AutoscrollController.cpp

diff --git a/third_party/WebKit/Source/core/page/AutoscrollController.cpp b/third_party/WebKit/Source/core/page/AutoscrollController.cpp

index 4765eafa763028118062592e6d089c936ef68715..ab94c72c659066921957ed123bd6d1f8589fb5e6 100644

--- a/third_party/WebKit/Source/core/page/AutoscrollController.cpp

+++ b/third_party/WebKit/Source/core/page/AutoscrollController.cpp

@@ -76,8 +76,6 @@ void AutoscrollController::StartAutoscrollForSelection(

// it's already active.

if (autoscroll_type_ != kNoAutoscroll)

return;

- if (layout_object)

- layout_object->GetFrameView()->UpdateAllLifecyclePhasesExceptPaint();

LayoutBox* scrollable = LayoutBox::FindAutoscrollable(layout_object);

if (!scrollable)

scrollable =