Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h

Issue 2844543002: SerializedScriptValue: Add a warning about making wire format changes near branch. (Closed)
Patch Set: update wording Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 // Version 8: File.lastModified in milliseconds (seconds-based in earlier 73 // Version 8: File.lastModified in milliseconds (seconds-based in earlier
74 // versions.) 74 // versions.)
75 // Version 9: Added Map and Set support. 75 // Version 9: Added Map and Set support.
76 // [versions skipped] 76 // [versions skipped]
77 // Version 16: Separate versioning between V8 and Blink. 77 // Version 16: Separate versioning between V8 and Blink.
78 // Version 17: Remove unnecessary byte swapping. 78 // Version 17: Remove unnecessary byte swapping.
79 // 79 //
80 // The following versions cannot be used, in order to be able to 80 // The following versions cannot be used, in order to be able to
81 // deserialize version 0 SSVs. The class implementation has details. 81 // deserialize version 0 SSVs. The class implementation has details.
82 // DO NOT USE: 35, 64, 68, 73, 78, 82, 83, 85, 91, 98, 102, 108, 123. 82 // DO NOT USE: 35, 64, 68, 73, 78, 82, 83, 85, 91, 98, 102, 108, 123.
83 //
84 // WARNING: Increasing this value is a change which cannot safely be rolled
85 // back without breaking compatibility with data stored on disk. It is
86 // strongly recommended that you do not make such changes near a release
87 // milestone branch point.
88 //
89 // Recent changes are routinely reverted in preparation for branch, and this
90 // has been the cause of at least one bug in the past.
83 static constexpr uint32_t kWireFormatVersion = 17; 91 static constexpr uint32_t kWireFormatVersion = 17;
84 92
85 struct SerializeOptions { 93 struct SerializeOptions {
86 STACK_ALLOCATED(); 94 STACK_ALLOCATED();
87 Transferables* transferables = nullptr; 95 Transferables* transferables = nullptr;
88 WebBlobInfoArray* blob_info = nullptr; 96 WebBlobInfoArray* blob_info = nullptr;
89 bool write_wasm_to_stream = false; 97 bool write_wasm_to_stream = false;
90 }; 98 };
91 static PassRefPtr<SerializedScriptValue> Serialize(v8::Isolate*, 99 static PassRefPtr<SerializedScriptValue> Serialize(v8::Isolate*,
92 v8::Local<v8::Value>, 100 v8::Local<v8::Value>,
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 ExceptionState& exception_state) { 231 ExceptionState& exception_state) {
224 return SerializedScriptValue::Serialize( 232 return SerializedScriptValue::Serialize(
225 isolate, value, SerializedScriptValue::SerializeOptions(), 233 isolate, value, SerializedScriptValue::SerializeOptions(),
226 exception_state); 234 exception_state);
227 } 235 }
228 }; 236 };
229 237
230 } // namespace blink 238 } // namespace blink
231 239
232 #endif // SerializedScriptValue_h 240 #endif // SerializedScriptValue_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698