net/quic/chromium/quic_http_stream.h - Issue 2844493002: QuicChromiumClientSession::StreamRequest to be created by the session

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/quic_http_stream.h

Issue 2844493002: QuicChromiumClientSession::StreamRequest to be created by the session (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/quic_http_stream.h

diff --git a/net/quic/chromium/quic_http_stream.h b/net/quic/chromium/quic_http_stream.h

index ca36241d918c5b0480370b59fd644664ae0ffd6a..df61ef52c4672d8fb6d3a751e4226e62fb545e63 100644

--- a/net/quic/chromium/quic_http_stream.h

+++ b/net/quic/chromium/quic_http_stream.h

@@ -159,7 +159,7 @@ class NET_EXPORT_PRIVATE QuicHttpStream

QuicVersion quic_version_;

int session_error_; // Error code from the connection shutdown.

bool was_handshake_confirmed_; // True if the crypto handshake succeeded.

- QuicChromiumClientSession::StreamRequest stream_request_;

+ std::unique_ptr<QuicChromiumClientSession::StreamRequest> stream_request_;

QuicChromiumClientStream* stream_; // Non-owning.

// The following three fields are all owned by the caller and must