Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl.cc

Issue 2844493002: QuicChromiumClientSession::StreamRequest to be created by the session (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/bidirectional_stream_quic_impl.cc
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl.cc b/net/quic/chromium/bidirectional_stream_quic_impl.cc
index 513b2e29eed3412ed7ec62b3911958b3de43f213..04278f130d8abfb5dff37e1c1281e8440a3d729e 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl.cc
+++ b/net/quic/chromium/bidirectional_stream_quic_impl.cc
@@ -73,10 +73,9 @@ void BidirectionalStreamQuicImpl::Start(
delegate_ = delegate;
request_info_ = request_info;
- int rv = stream_request_.StartRequest(
- session_, &stream_,
- base::Bind(&BidirectionalStreamQuicImpl::OnStreamReady,
- weak_factory_.GetWeakPtr()));
+ stream_request_ = session_->CreateStreamRequest();
+ int rv = stream_request_->StartRequest(base::Bind(
+ &BidirectionalStreamQuicImpl::OnStreamReady, weak_factory_.GetWeakPtr()));
if (rv == OK) {
OnStreamReady(rv);
} else if (!was_handshake_confirmed_) {
@@ -306,6 +305,8 @@ void BidirectionalStreamQuicImpl::OnStreamReady(int rv) {
DCHECK_NE(ERR_IO_PENDING, rv);
DCHECK(rv == OK || !stream_);
if (rv == OK) {
+ stream_ = stream_request_->ReleaseStream();
+ stream_request_.reset();
stream_->SetDelegate(this);
if (!was_handshake_confirmed_ && request_info_->method == "POST") {
waiting_for_confirmation_ = true;
« no previous file with comments | « net/quic/chromium/bidirectional_stream_quic_impl.h ('k') | net/quic/chromium/quic_chromium_client_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698