third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.idl - Issue 2844453002: Update CM API IDL to use SecureContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.idl

Issue 2844453002: Update CM API IDL to use SecureContext (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/credentialmanager/CredentialUserData.idl ('K') | « third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl ('k') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl » ('j') | third_party/WebKit/Source/web/WebRuntimeFeatures.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.idl

diff --git a/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.idl b/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.idl

index 35b163be27b4c49b9c0cd5903e002a3d0e2a95d3..5c87688ab2f9cbc26383b0b4ddc7348998387696 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.idl

+++ b/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.idl

@@ -2,8 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

- RuntimeEnabled=CredentialManager,

-] partial interface Navigator {

+[SecureContext, SameObject]

+partial interface Navigator {

readonly attribute CredentialsContainer credentials;

Mike West 2017/04/25 18:39:45 Please put the attributes on the attribute, not th

jdoerrie 2017/04/26 12:20:35 Done.

};