Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js

Issue 284443002: [fsp] Add support for opening files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up + added custom bindings. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the fileSystemProvider API. 5 // Custom binding for the fileSystemProvider API.
6 6
7 var binding = require('binding').Binding.create('fileSystemProvider'); 7 var binding = require('binding').Binding.create('fileSystemProvider');
8 var fileSystemProviderInternal = 8 var fileSystemProviderInternal =
9 require('binding').Binding.create('fileSystemProviderInternal').generate(); 9 require('binding').Binding.create('fileSystemProviderInternal').generate();
10 var eventBindings = require('event_bindings'); 10 var eventBindings = require('event_bindings');
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 fileSystemId, requestId, annotatedEntries, hasNext); 154 fileSystemId, requestId, annotatedEntries, hasNext);
155 }; 155 };
156 var onErrorCallback = function(error) { 156 var onErrorCallback = function(error) {
157 fileSystemProviderInternal.readDirectoryRequestedError( 157 fileSystemProviderInternal.readDirectoryRequestedError(
158 fileSystemId, requestId, error); 158 fileSystemId, requestId, error);
159 } 159 }
160 dispatch([ 160 dispatch([
161 fileSystemId, directoryPath, onSuccessCallback, onErrorCallback]); 161 fileSystemId, directoryPath, onSuccessCallback, onErrorCallback]);
162 }); 162 });
163 163
164 eventBindings.registerArgumentMassager(
165 'fileSystemProvider.onOpenFileRequested',
166 function(args, dispatch) {
167 var fileSystemId = args[0];
168 var requestId = args[1];
169 var onSuccessCallback = function() {
170 fileSystemProviderInternal.openFileRequestedSuccess(
171 fileSystemId, requestId);
172 };
173 var onErrorCallback = function(error) {
174 fileSystemProviderInternal.openFileRequestedError(
175 fileSystemId, requestId, error);
176 }
177 dispatch([fileSystemId, onSuccessCallback, onErrorCallback]);
kinaba 2014/05/13 01:30:35 Main arguments (path, create, mode) look to be mis
mtomasz 2014/05/13 01:55:01 Good catch. Done. I'll add browser tests, once the
178 });
179
164 exports.binding = binding.generate(); 180 exports.binding = binding.generate();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698