Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 284443002: [fsp] Add support for opening files. (Closed)

Created:
6 years, 7 months ago by mtomasz
Modified:
6 years, 7 months ago
Reviewers:
benwells, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jar (doing other things)
Visibility:
Public.

Description

[fsp] Add support for opening files. This patch adds support to opening a file. It is currently no-op, and it is not yet bound to fileapi. In order to bound it to fileapi::AsyncFileUtil, we need to implement closing operation, and reading operations first. Otherwise, creating a snapshot (required by fileapi::AsyncFileUtil) is not possible. TEST=unit_tests: *FileSystemProvider*OpenFile* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270040

Patch Set 1 #

Patch Set 2 : IDL cleanup. #

Patch Set 3 : Cleaned up + added custom bindings. #

Total comments: 4

Patch Set 4 : Addressed comments. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -21 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/open_file.h View 3 chunks +20 lines, -14 lines 0 comments Download
A chrome/browser/chromeos/file_system_provider/operations/open_file.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc View 1 chunk +215 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 5 chunks +29 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 2 3 3 chunks +19 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_internal.idl View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtomasz
@kinaba: PTAL. This is mostly a copy-paste of previous operations. @benwells: PTAL at *.idl. Thanks.
6 years, 7 months ago (2014-05-12 07:07:26 UTC) #1
benwells
idl lgtm
6 years, 7 months ago (2014-05-12 22:49:28 UTC) #2
kinaba
https://codereview.chromium.org/284443002/diff/40001/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/284443002/diff/40001/chrome/common/extensions/api/file_system_provider.idl#newcode144 chrome/common/extensions/api/file_system_provider.idl:144: ProviderErrorCallback errorCallback); Where's the <code>create</code> and open mode parameter? ...
6 years, 7 months ago (2014-05-13 01:30:35 UTC) #3
mtomasz
https://codereview.chromium.org/284443002/diff/40001/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/284443002/diff/40001/chrome/common/extensions/api/file_system_provider.idl#newcode144 chrome/common/extensions/api/file_system_provider.idl:144: ProviderErrorCallback errorCallback); On 2014/05/13 01:30:35, kinaba wrote: > Where's ...
6 years, 7 months ago (2014-05-13 01:55:00 UTC) #4
kinaba
lgtm
6 years, 7 months ago (2014-05-13 01:56:15 UTC) #5
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-13 02:20:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/284443002/80001
6 years, 7 months ago (2014-05-13 02:20:49 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 07:12:44 UTC) #8
Message was sent while issue was closed.
Change committed as 270040

Powered by Google App Engine
This is Rietveld 408576698