Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chromecast/browser/android/cast_web_contents_activity.h

Issue 2844413004: Switch SupportsUserData uses to use unique_ptr. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromecast/browser/android/cast_web_contents_activity.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/android/cast_web_contents_activity.h
diff --git a/chromecast/browser/android/cast_web_contents_activity.h b/chromecast/browser/android/cast_web_contents_activity.h
index 37684bf0f579b0e60b93ee7115312cd03a9aa653..90404d8fcf3ee22a026dd77c0602daa8d1af9598 100644
--- a/chromecast/browser/android/cast_web_contents_activity.h
+++ b/chromecast/browser/android/cast_web_contents_activity.h
@@ -21,8 +21,10 @@ namespace shell {
// Helper class to get members of the CastWebContentsActivity displaying a
// given web_contents. This class is lazily created through the Get function and
// will manage its own lifetime via SupportsUserData.
-class CastWebContentsActivity : base::SupportsUserData::Data {
+class CastWebContentsActivity : public base::SupportsUserData::Data {
public:
+ ~CastWebContentsActivity() override;
+
static bool RegisterJni(JNIEnv* env);
static CastWebContentsActivity* Get(content::WebContents* web_contents);
@@ -32,7 +34,6 @@ class CastWebContentsActivity : base::SupportsUserData::Data {
private:
explicit CastWebContentsActivity(content::WebContents* web_contents);
- ~CastWebContentsActivity() override;
base::android::ScopedJavaGlobalRef<jobject> content_video_view_embedder_;
« no previous file with comments | « no previous file | chromecast/browser/android/cast_web_contents_activity.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698