Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Side by Side Diff: chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm

Issue 2844393003: Remove dead Page Info permission strings and associated code. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/page_info/page_info_ui.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h" 5 #import "chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h"
6 6
7 #import <AppKit/AppKit.h> 7 #import <AppKit/AppKit.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 10
(...skipping 1097 matching lines...) Expand 10 before | Expand all | Expand 10 after
1108 } 1108 }
1109 1109
1110 - (void)setPermissionInfo:(const PermissionInfoList&)permissionInfoList 1110 - (void)setPermissionInfo:(const PermissionInfoList&)permissionInfoList
1111 andChosenObjects:(ChosenObjectInfoList)chosenObjectInfoList { 1111 andChosenObjects:(ChosenObjectInfoList)chosenObjectInfoList {
1112 [permissionsView_ setSubviews:[NSArray array]]; 1112 [permissionsView_ setSubviews:[NSArray array]];
1113 NSPoint controlOrigin = NSMakePoint(kSectionHorizontalPadding, 0); 1113 NSPoint controlOrigin = NSMakePoint(kSectionHorizontalPadding, 0);
1114 1114
1115 permissionsPresent_ = YES; 1115 permissionsPresent_ = YES;
1116 1116
1117 if (permissionInfoList.size() > 0 || chosenObjectInfoList.size() > 0) { 1117 if (permissionInfoList.size() > 0 || chosenObjectInfoList.size() > 0) {
1118 base::string16 sectionTitle =
1119 l10n_util::GetStringUTF16(IDS_PAGE_INFO_TITLE_SITE_PERMISSIONS);
1120
1121 for (const auto& permission : permissionInfoList) { 1118 for (const auto& permission : permissionInfoList) {
1122 controlOrigin.y += kPermissionsVerticalSpacing; 1119 controlOrigin.y += kPermissionsVerticalSpacing;
1123 NSPoint rowBottomRight = [self addPermission:permission 1120 NSPoint rowBottomRight = [self addPermission:permission
1124 toView:permissionsView_ 1121 toView:permissionsView_
1125 atPoint:controlOrigin]; 1122 atPoint:controlOrigin];
1126 controlOrigin.y = rowBottomRight.y; 1123 controlOrigin.y = rowBottomRight.y;
1127 } 1124 }
1128 1125
1129 for (auto& object : chosenObjectInfoList) { 1126 for (auto& object : chosenObjectInfoList) {
1130 controlOrigin.y += kPermissionsVerticalSpacing; 1127 controlOrigin.y += kPermissionsVerticalSpacing;
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
1219 void PageInfoUIBridge::SetCookieInfo(const CookieInfoList& cookie_info_list) { 1216 void PageInfoUIBridge::SetCookieInfo(const CookieInfoList& cookie_info_list) {
1220 [bubble_controller_ setCookieInfo:cookie_info_list]; 1217 [bubble_controller_ setCookieInfo:cookie_info_list];
1221 } 1218 }
1222 1219
1223 void PageInfoUIBridge::SetPermissionInfo( 1220 void PageInfoUIBridge::SetPermissionInfo(
1224 const PermissionInfoList& permission_info_list, 1221 const PermissionInfoList& permission_info_list,
1225 ChosenObjectInfoList chosen_object_info_list) { 1222 ChosenObjectInfoList chosen_object_info_list) {
1226 [bubble_controller_ setPermissionInfo:permission_info_list 1223 [bubble_controller_ setPermissionInfo:permission_info_list
1227 andChosenObjects:std::move(chosen_object_info_list)]; 1224 andChosenObjects:std::move(chosen_object_info_list)];
1228 } 1225 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/page_info/page_info_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698