Turn ArcSupportHost from Observer model to Delegate

chrome/browser/chromeos/arc/extensions/fake_arc_support.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/extensions/fake_arc_support.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/arc/extensions/arc_support_message_host.h"
 
 namespace arc {
 
 FakeArcSupport::FakeArcSupport(ArcSupportHost* support_host)
     : support_host_(support_host), weak_ptr_factory_(this) {
   DCHECK(support_host_);
   support_host_->SetRequestOpenAppCallbackForTesting(
       base::Bind(&FakeArcSupport::Open, weak_ptr_factory_.GetWeakPtr()));
 }
 
 FakeArcSupport::~FakeArcSupport() {
   // Ensure that message host is disconnected.
-  if (native_message_host_)
-    Close();
+  if (native_message_host_) {

[Luis Héctor Chávez, 2017/05/30 16:06:27]

nit: use guard clause pattern

if (!native_message_host_)
  return;
// rest

also, maybe consider refactoring these two lines so that both Close() and
~FakeArcSupport() can call them to avoid the repetition.

[victorhsieh0, 2017/05/30 19:52:42]

Done.

+    support_host_->UnsetMessageHost(
+        static_cast<ArcSupportMessageHost*>(native_message_host_.get()));
+    native_message_host_.reset();
+  }
 }
 
 void FakeArcSupport::Open(Profile* profile) {
   DCHECK(!native_message_host_);
   native_message_host_ = ArcSupportMessageHost::Create();
   native_message_host_->Start(this);
   support_host_->SetMessageHost(
       static_cast<ArcSupportMessageHost*>(native_message_host_.get()));
 }
 
 void FakeArcSupport::Close() {
   DCHECK(native_message_host_);
   native_message_host_->OnMessage("{\"event\": \"onWindowClosed\"}");
   support_host_->UnsetMessageHost(
       static_cast<ArcSupportMessageHost*>(native_message_host_.get()));
   native_message_host_.reset();
 }
 
+void FakeArcSupport::EmulateAuthCodeResponse(const std::string& auth_code) {
+  DCHECK_EQ(ui_page_, ArcSupportHost::UIPage::LSO);
+  base::DictionaryValue message;
+  message.SetString("event", "onAuthSucceeded");
+  message.SetString("code", auth_code);
+  OnMessage(message);
+}
+
+void FakeArcSupport::EmulateAuthFailure() {
+  DCHECK(native_message_host_);
+  DCHECK_EQ(ui_page_, ArcSupportHost::UIPage::LSO);
+  native_message_host_->OnMessage("{\"event\": \"onAuthFailed\"}");
+}
+
 void FakeArcSupport::ClickAgreeButton() {
-  DCHECK(native_message_host_);
   DCHECK_EQ(ui_page_, ArcSupportHost::UIPage::TERMS);
 
   base::DictionaryValue message;
   message.SetString("event", "onAgreed");
   message.SetBoolean("isMetricsEnabled", metrics_mode_);
   message.SetBoolean("isBackupRestoreEnabled", backup_and_restore_mode_);
   message.SetBoolean("isLocationServiceEnabled", location_service_mode_);
-
-  std::string message_string;
-  if (!base::JSONWriter::Write(message, &message_string)) {
-    NOTREACHED();
-    return;
-  }
-  native_message_host_->OnMessage(message_string);
+  OnMessage(message);
 }
 
 void FakeArcSupport::ClickRetryButton() {
   DCHECK(native_message_host_);
   DCHECK_EQ(ui_page_, ArcSupportHost::UIPage::ERROR);
   native_message_host_->OnMessage("{\"event\": \"onRetryClicked\"}");
 }
 
+void FakeArcSupport::ClickSendFeedbackButton() {
+  DCHECK(native_message_host_);
+  DCHECK_EQ(ui_page_, ArcSupportHost::UIPage::ERROR);
+  native_message_host_->OnMessage("{\"event\": \"onSendFeedbackClicked\"}");
+}
+
 void FakeArcSupport::PostMessageFromNativeHost(
     const std::string& message_string) {
   std::unique_ptr<base::DictionaryValue> message =
       base::DictionaryValue::From(base::JSONReader::Read(message_string));
   DCHECK(message);
 
   std::string action;
   if (!message->GetString("action", &action)) {
     NOTREACHED() << message_string;
     return;
@@ skipping 36 matching lines @@
   } else {
     // Unknown or unsupported action.
     NOTREACHED() << message_string;
   }
 }
 
 void FakeArcSupport::CloseChannel(const std::string& error_message) {
   NOTREACHED();
 }
 
+void FakeArcSupport::OnMessage(const base::DictionaryValue& message) {
+  DCHECK(native_message_host_);
+  std::string message_string;
+  if (!base::JSONWriter::Write(message, &message_string)) {
+    NOTREACHED();
+    return;
+  }
+  native_message_host_->OnMessage(message_string);
+}
+
 }  // namespace arc