Turn ArcSupportHost from Observer model to Delegate

chrome/browser/chromeos/arc/arc_support_host_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/arc/arc_support_host.h"
+
+#include "base/memory/ptr_util.h"
+#include "chrome/browser/chromeos/arc/extensions/fake_arc_support.h"
+#include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
+#include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using arc::FakeArcSupport;
+using testing::_;
+using testing::Eq;
+using testing::StrictMock;
+
+namespace {
+
+class MockAuthDelegateNonStrict : public ArcSupportHost::AuthDelegate {
+ public:
+  MOCK_METHOD1(OnAuthSucceeded, void(const std::string& auth_code));
+  MOCK_METHOD0(OnAuthFailed, void());
+  MOCK_METHOD0(OnAuthRetryClicked, void());
+};
+
+using MockAuthDelegate = StrictMock<MockAuthDelegateNonStrict>;
+
+class MockTermsOfServiceDelegateNonStrict
+    : public ArcSupportHost::TermsOfServiceDelegate {
+ public:
+  MOCK_METHOD3(OnTermsAgreed,
+               void(bool is_metrics_enabled,
+                    bool is_backup_and_restore_enabled,
+                    bool is_location_service_enabled));
+  MOCK_METHOD0(OnTermsRejected, void());
+  MOCK_METHOD0(OnTermsRetryClicked, void());
+};
+
+using MockTermsOfServiceDelegate =
+    StrictMock<MockTermsOfServiceDelegateNonStrict>;
+
+class MockErrorDelegateNonStrict : public ArcSupportHost::ErrorDelegate {
+ public:
+  MOCK_METHOD0(OnWindowClosedTermsAccepted, void());
+  MOCK_METHOD0(OnRetryClicked, void());
+  MOCK_METHOD0(OnSendFeedbackClicked, void());
+};
+
+using MockErrorDelegate = StrictMock<MockErrorDelegateNonStrict>;
+
+class ArcSupportHostTest : public testing::Test {
+ public:
+  ArcSupportHostTest() = default;
+  ~ArcSupportHostTest() override = default;
+
+  void SetUp() override {
+    user_manager_enabler_ =
+        base::MakeUnique<chromeos::ScopedUserManagerEnabler>(
+            new chromeos::FakeChromeUserManager());
+
+    profile_ = base::MakeUnique<TestingProfile>();
+    support_host_ = base::MakeUnique<ArcSupportHost>(profile_.get());
+    fake_arc_support_ = base::MakeUnique<FakeArcSupport>(support_host_.get());
+  }
+
+  void TearDown() override {
+    support_host_->SetAuthDelegate(nullptr);
+    support_host_->SetTermsOfServiceDelegate(nullptr);
+    support_host_->SetErrorDelegate(nullptr);
+
+    fake_arc_support_.reset();
+    support_host_.reset();
+    profile_.reset();
+    user_manager_enabler_.reset();
+  }
+
+  ArcSupportHost* support_host() { return support_host_.get(); }
+  FakeArcSupport* fake_arc_support() { return fake_arc_support_.get(); }
+
+  MockAuthDelegate* CreateMockAuthDelegate() {
+    auth_delegate_ = base::MakeUnique<MockAuthDelegate>();
+    support_host_->SetAuthDelegate(auth_delegate_.get());
+    return auth_delegate_.get();
+  }
+
+  MockTermsOfServiceDelegate* CreateMockTermsOfServiceDelegate() {
+    tos_delegate_ = base::MakeUnique<MockTermsOfServiceDelegate>();
+    support_host_->SetTermsOfServiceDelegate(tos_delegate_.get());
+    return tos_delegate_.get();
+  }
+
+  MockErrorDelegate* CreateMockErrorDelegate() {
+    error_delegate_ = base::MakeUnique<MockErrorDelegate>();
+    support_host_->SetErrorDelegate(error_delegate_.get());
+    return error_delegate_.get();
+  }
+
+ private:
+  // Fake as if the current testing thread is UI thread.
+  content::TestBrowserThreadBundle bundle_;
+
+  std::unique_ptr<TestingProfile> profile_;
+  std::unique_ptr<ArcSupportHost> support_host_;
+  std::unique_ptr<FakeArcSupport> fake_arc_support_;
+  std::unique_ptr<chromeos::ScopedUserManagerEnabler> user_manager_enabler_;
+
+  std::unique_ptr<MockAuthDelegate> auth_delegate_;
+  std::unique_ptr<MockTermsOfServiceDelegate> tos_delegate_;
+  std::unique_ptr<MockErrorDelegate> error_delegate_;
+
+  DISALLOW_COPY_AND_ASSIGN(ArcSupportHostTest);
+};
+
+TEST_F(ArcSupportHostTest, AuthSucceeded) {
+  MockAuthDelegate* auth_delegate = CreateMockAuthDelegate();
+  support_host()->SetAuthDelegate(auth_delegate);
+
+  support_host()->ShowLso();
+
+  EXPECT_CALL(*auth_delegate, OnAuthSucceeded(Eq("fake_code")));

[Luis Héctor Chávez, 2017/05/30 16:06:27]

nit: maybe make this literal a constexpr char[] here in this method.

[victorhsieh0, 2017/05/30 19:52:42]

Done.

+  fake_arc_support()->EmulateAuthCodeResponse("fake_code");
+}
+
+TEST_F(ArcSupportHostTest, AuthFailed) {
+  MockAuthDelegate* auth_delegate = CreateMockAuthDelegate();
+  support_host()->SetAuthDelegate(auth_delegate);
+
+  support_host()->ShowLso();
+
+  EXPECT_CALL(*auth_delegate, OnAuthFailed());
+  fake_arc_support()->EmulateAuthFailure();
+}
+
+TEST_F(ArcSupportHostTest, AuthRetryOnError) {
+  // Auth error can only happen after terms accepted.
+  MockAuthDelegate* auth_delegate = CreateMockAuthDelegate();
+  support_host()->SetAuthDelegate(auth_delegate);
+  MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
+  support_host()->SetErrorDelegate(error_delegate);
+
+  support_host()->ShowError(ArcSupportHost::Error::NETWORK_UNAVAILABLE_ERROR,
+                            false /* should_show_send_feedback */);
+
+  EXPECT_CALL(*auth_delegate, OnAuthRetryClicked());
+  EXPECT_CALL(*error_delegate, OnWindowClosedTermsAccepted()).Times(0);
+  fake_arc_support()->ClickRetryButton();
+}
+
+TEST_F(ArcSupportHostTest, TermsOfServiceAccept) {
+  MockTermsOfServiceDelegate tos_delegate;
+  support_host()->SetTermsOfServiceDelegate(&tos_delegate);
+
+  support_host()->ShowTermsOfService();
+  fake_arc_support()->set_metrics_mode(false);  // just to add some diversity
+  fake_arc_support()->set_backup_and_restore_mode(true);
+  fake_arc_support()->set_location_service_mode(true);
+
+  EXPECT_CALL(tos_delegate, OnTermsAgreed(false, true, true));
+  fake_arc_support()->ClickAgreeButton();
+}
+
+TEST_F(ArcSupportHostTest, TermsOfServiceRejectOrCloseWindow) {
+  MockTermsOfServiceDelegate* tos_delegate = CreateMockTermsOfServiceDelegate();
+  support_host()->SetTermsOfServiceDelegate(tos_delegate);
+  MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
+  support_host()->SetErrorDelegate(error_delegate);
+
+  support_host()->ShowTermsOfService();
+
+  EXPECT_CALL(*tos_delegate, OnTermsRejected());
+  EXPECT_CALL(*error_delegate, OnWindowClosedTermsAccepted()).Times(0);
+  // Rejecting ToS and closing the window when ToS is showing is the same thing.
+  fake_arc_support()->Close();
+}
+
+TEST_F(ArcSupportHostTest, TermsOfServiceRetryOnError) {
+  MockTermsOfServiceDelegate* tos_delegate = CreateMockTermsOfServiceDelegate();
+  support_host()->SetTermsOfServiceDelegate(tos_delegate);
+  MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
+  support_host()->SetErrorDelegate(error_delegate);
+
+  support_host()->ShowError(ArcSupportHost::Error::NETWORK_UNAVAILABLE_ERROR,
+                            false /* should_show_send_feedback */);
+
+  EXPECT_CALL(*tos_delegate, OnTermsRetryClicked());
+  EXPECT_CALL(*error_delegate, OnWindowClosedTermsAccepted()).Times(0);
+  fake_arc_support()->ClickRetryButton();
+}
+
+TEST_F(ArcSupportHostTest, CloseWindowDuringManualAuth) {
+  // No TermsOfServiceDelegate since it is not ongoing.
+  MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
+  support_host()->SetErrorDelegate(error_delegate);
+  MockAuthDelegate* auth_delegate = CreateMockAuthDelegate();
+  support_host()->SetAuthDelegate(auth_delegate);
+
+  support_host()->ShowArcLoading();
+
+  EXPECT_CALL(*error_delegate, OnWindowClosedTermsAccepted());
+  fake_arc_support()->Close();
+}
+
+TEST_F(ArcSupportHostTest, CloseWindowWithoutTermsOfServiceOrAuthOnging) {
+  // No TermsOfServiceDelegate since it is not ongoing.
+  MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
+  support_host()->SetErrorDelegate(error_delegate);
+
+  support_host()->ShowArcLoading();
+
+  EXPECT_CALL(*error_delegate, OnWindowClosedTermsAccepted());
+  fake_arc_support()->Close();
+}
+
+TEST_F(ArcSupportHostTest, RetryOnGeneralError) {
+  // No TermsOfServiceDelegate and AuthDelegate since it is not ongoing.
+  MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
+  support_host()->SetErrorDelegate(error_delegate);
+
+  support_host()->ShowError(ArcSupportHost::Error::NETWORK_UNAVAILABLE_ERROR,
+                            false /* should_show_send_feedback */);
+
+  EXPECT_CALL(*error_delegate, OnRetryClicked());
+  fake_arc_support()->ClickRetryButton();
+}
+
+TEST_F(ArcSupportHostTest, SendFeedbackOnError) {
+  MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
+  support_host()->SetErrorDelegate(error_delegate);
+
+  support_host()->ShowError(ArcSupportHost::Error::NETWORK_UNAVAILABLE_ERROR,
+                            true /* should_show_send_feedback */);
+
+  EXPECT_CALL(*error_delegate, OnSendFeedbackClicked());
+  fake_arc_support()->ClickSendFeedbackButton();
+}
+
+}  // namespace