chrome/browser/installable/installable_metrics.h - Issue 2844383004: Split the NOT_STARTED and STOPPED_BEFORE_COMPLETION installability metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/installable/installable_metrics.h

Issue 2844383004: Split the NOT_STARTED and STOPPED_BEFORE_COMPLETION installability metrics. (Closed)

Patch Set: Actually record early failures as failures Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/installable/installable_metrics.h

diff --git a/chrome/browser/installable/installable_metrics.h b/chrome/browser/installable/installable_metrics.h

index 58e587855bb42411e20f075e0ac3df752ed79e55..1350660db5c09039ef17d9300cb0290750405734 100644

--- a/chrome/browser/installable/installable_metrics.h

+++ b/chrome/browser/installable/installable_metrics.h

@@ -8,7 +8,7 @@

// This enum backs a UMA histogram and must be treated as append-only.

enum class InstallabilityCheckStatus {

NOT_STARTED,

- STOPPED_BEFORE_COMPLETION,

+ NOT_COMPLETED,

IN_PROGRESS_NON_PROGRESSIVE_WEB_APP,

IN_PROGRESS_PROGRESSIVE_WEB_APP,

COMPLETE_NON_PROGRESSIVE_WEB_APP,