Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(254)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chromeos/test/data/network/tether.onc
Issue
2844363003
:
[CrOS Tether] Add HasConnectedToHost property for Tether networks. (Closed)
Patch Set:
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
chromeos/network/network_configuration_handler_unittest.cc
chromeos/network/network_state.h
chromeos/network/network_state.cc
chromeos/network/network_state_handler.cc
chromeos/network/network_state_unittest.cc
chromeos/network/onc/onc_signature.cc
chromeos/network/onc/onc_translation_tables.cc
chromeos/network/onc/onc_validator.cc
chromeos/network/onc/onc_validator_unittest.cc
chromeos/network/tether_constants.h
chromeos/network/tether_constants.cc
chromeos/test/data/network/invalid_settings_with_repairs.json
chromeos/test/data/network/shill_tether.json
chromeos/test/data/network/tether.onc
components/onc/docs/onc_spec.md
components/onc/onc_constants.h
components/onc/onc_constants.cc
extensions/common/api/networking_private.idl
third_party/closure_compiler/externs/networking_private.js
View unified diff
|
Download patch
« chromeos/network/network_state_handler.cc
('K') |
« chromeos/test/data/network/shill_tether.json
('k') |
components/onc/docs/onc_spec.md »
('j') |
components/onc/docs/onc_spec.md »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 {
1 {
2 "Type": "Tether",
2 "Type": "Tether",
3 "Name": "Tether Network",
3 "Name": "Tether Network",
4 "Tether": {
4 "Tether": {
5 "BatteryPercentage": 85,
5 "BatteryPercentage": 85,
6 "Carrier": "Project Fi",
6 "Carrier": "Project Fi",
7
"HasConnectedToHost": true,
7 "SignalStrength": 75
8 "SignalStrength": 75
8 }
9 }
9 }
10 }
OLD
NEW
« chromeos/network/network_state_handler.cc
('K') |
« chromeos/test/data/network/shill_tether.json
('k') |
components/onc/docs/onc_spec.md »
('j') |
components/onc/docs/onc_spec.md »
('J')
Issue 2844363003: [CrOS Tether] Add HasConnectedToHost property for Tether networks. (Closed)
Created 3 years, 7 months ago by Kyle Horimoto
Modified 3 years, 7 months ago
Reviewers: Ken Rockot(use gerrit already), stevenjb
Base URL:
Comments: 12
This is Rietveld
408576698
Chromium Code Reviews
Issue 2844363003:
[CrOS Tether] Add HasConnectedToHost property for Tether networks. (Closed)
