Wrap front-end inference tests into a reflective test.

pkg/analyzer/test/src/task/strong/front_end_inference_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:front_end/src/base/instrumentation.dart' as fasta;
 import 'package:front_end/src/fasta/compiler_context.dart' as fasta;
 import 'package:front_end/src/fasta/testing/validating_instrumentation.dart'
     as fasta;
 import 'package:kernel/kernel.dart' as fasta;
 import 'package:path/path.dart' as pathos;
 import 'package:test/test.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../../dart/analysis/base.dart';
 
-Future<Null> main() async {
-  await _runFrontEndInferenceTests();
+main() {
+  defineReflectiveSuite(() {
+    defineReflectiveTests(RunFrontEndInferenceTest);
+  });
 }
 
-/**
- * Expects that the [Platform.script] is a test inside of `pkg/analyzer/test`
- * folder, and return the absolute path of the `pkg` folder.
- */
-String _findPkgRoot() {
-  String scriptPath = pathos.fromUri(Platform.script);
-  List<String> parts = pathos.split(scriptPath);
-  for (int i = 0; i < parts.length - 2; i++) {
-    if (parts[i] == 'pkg' &&
-        parts[i + 1] == 'analyzer' &&
-        parts[i + 2] == 'test') {
-      return pathos.joinAll(parts.sublist(0, i + 1));
+@reflectiveTest
+class RunFrontEndInferenceTest {
+  test_run() async {
+    String pkgPath = _findPkgRoot();
+    String fePath = pathos.join(pkgPath, 'front_end', 'testcases', 'inference');
+    List<File> dartFiles = new Directory(fePath)
+        .listSync()
+        .where((entry) => entry is File && entry.path.endsWith('.dart'))
+        .map((entry) => entry as File)
+        .toList();
+
+    var allProblems = new StringBuffer();
+    for (File file in dartFiles) {
+      var test = new _FrontEndInferenceTest();
+      await test.setUp();
+      try {
+        String code = file.readAsStringSync();
+        await test.runTest(file.path, code);
+      } on String catch (problems) {
+        allProblems.writeln(problems);
+      } finally {
+        await test.tearDown();
+      }
+    }
+    if (allProblems.isNotEmpty) {
+      fail(allProblems.toString());
     }
   }
-  throw new StateError('Unable to find sdk/pkg/ in $scriptPath');
-}
 
-Future<Null> _runFrontEndInferenceTests() async {
-  String pkgPath = _findPkgRoot();
-  String fePath = pathos.join(pkgPath, 'front_end', 'testcases', 'inference');
-  List<File> dartFiles = new Directory(fePath)
-      .listSync()
-      .where((entry) => entry is File && entry.path.endsWith('.dart'))
-      .map((entry) => entry as File)
-      .toList();
-
-  for (File file in dartFiles) {
-    var test = new _FrontEndInferenceTest();
-    await test.setUp();
-    try {
-      String code = file.readAsStringSync();
-      await test.runTest(file.path, code);
-    } catch (_) {
-      print(_);
-    } finally {
-      await test.tearDown();
+  /**
+   * Expects that the [Platform.script] is a test inside of `pkg/analyzer/test`
+   * folder, and return the absolute path of the `pkg` folder.
+   */
+  String _findPkgRoot() {
+    String scriptPath = pathos.fromUri(Platform.script);
+    List<String> parts = pathos.split(scriptPath);
+    for (int i = 0; i < parts.length - 2; i++) {
+      if (parts[i] == 'pkg' &&
+          parts[i + 1] == 'analyzer' &&
+          parts[i + 2] == 'test') {
+        return pathos.joinAll(parts.sublist(0, i + 1));
+      }
     }
+    throw new StateError('Unable to find sdk/pkg/ in $scriptPath');
   }
 }
 
 class _FrontEndInferenceTest extends BaseAnalysisDriverTest {
   Future<Null> runTest(String path, String code) async {
     Uri uri = provider.pathContext.toUri(path);
 
     List<int> lineStarts = new LineInfo.fromContent(code).lineStarts;
     fasta.CompilerContext.current.uriToSource[uri.toString()] =
         new fasta.Source(lineStarts, UTF8.encode(code));
 
     var validation = new fasta.ValidatingInstrumentation();
     await validation.loadExpectations(uri);
 
     provider.newFile(path, code);
 
     AnalysisResult result = await driver.getResult(path);
     result.unit.accept(new _InstrumentationVisitor(validation, uri));
 
     validation.finish();
 
     if (validation.hasProblems) {
-      fail(validation.problemsAsString);
+      throw validation.problemsAsString;
     }
   }
 }
 
 /**
  * Instance of [InstrumentationValue] describing a [DartType].
  */
 class _InstrumentationValueForType extends fasta.InstrumentationValue {
   final DartType type;
 
@@ skipping 162 matching lines @@
   void _recordType(int offset, DartType type) {
     _instrumentation.record(
         uri, offset, 'type', new _InstrumentationValueForType(type));
   }
 
   void _recordTypeArguments(int offset, List<DartType> typeArguments) {
     _instrumentation.record(uri, offset, 'typeArgs',
         new _InstrumentationValueForTypeArgs(typeArguments));
   }
 }