Issue 2844343002: Tests for SimpleIdentifier.inGetterContext() updated in other CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2844343002: Tests for SimpleIdentifier.inGetterContext() updated in other CL. (Closed)

Created:
3 years, 7 months ago by scheglov

Modified:
3 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Tests for SimpleIdentifier.inGetterContext() updated in other CL. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8c391c1f14da6e4edb65db749cd73d222f959b59

Patch Set 1 #

Total comments: 1

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	pkg/analyzer/test/dart/ast/ast_test.dart	View		2 chunks	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm https://codereview.chromium.org/2844343002/diff/1/pkg/analyzer/test/dart/ast/ast_test.dart File pkg/analyzer/test/dart/ast/ast_test.dart (right): https://codereview.chromium.org/2844343002/diff/1/pkg/analyzer/test/dart/ast/ast_test.dart#newcode650 pkg/analyzer/test/dart/ast/ast_test.dart:650: VariableDeclaration variable = AstTestFactory.variableDeclaration('testt'); nit: doubled 't'

3 years, 7 months ago (2017-04-27 17:34:16 UTC) #2

scheglov

3 years, 7 months ago (2017-04-27 17:54:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c391c1f14da6e4edb65db749cd73d222f959b59 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages