chrome/android/java/res/layout/default_search_engine_first_run_fragment.xml - Issue 2844323003: 🔍 Add first run dialog for selecting search engine

Side by Side Diff: chrome/android/java/res/layout/default_search_engine_first_run_fragment.xml

Issue 2844323003: 🔍 Add first run dialog for selecting search engine (Closed)

Patch Set: 🔍 Add First Run dialog for selecting search engine Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/firstrun/DefaultSearchEngineFirstRunFragment.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6

	7 <!-- Layout used to present a set of default search engines to the user. -->

	8 <LinearLayout

	9 xmlns:android="http://schemas.android.com/apk/res/android"

	10 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	11 android:layout_width="match_parent"

	12 android:layout_height="match_parent"

	13 android:background="@color/signin_body_background"

	14 android:orientation="vertical" >

	15

	16 <FrameLayout
	Ted C 2017/05/04 00:16:56 Why do we need this? Any reason FirstRunChooserVi Why do we need this? Any reason FirstRunChooserView isn't here instead? gone 2017/05/04 00:28:11 FirstRunChooserView asserts its layout parameters Show quoted text On 2017/05/04 00:16:56, Ted C wrote: > Why do we need this? Any reason FirstRunChooserView isn't here instead? FirstRunChooserView asserts its layout parameters are match_parent. Don't know why, I just pulled it out into its own class -_-
	17 android:layout_width="match_parent"

	18 android:layout_height="0dp"

	19 android:layout_weight="1" >

	20

	21 <org.chromium.chrome.browser.firstrun.FirstRunChooserView

	22 android:layout_width="match_parent"

	23 android:layout_height="match_parent"

	24 android:fadeScrollbars="false"

	25 android:requiresFadingEdge="vertical"

	26 android:fadingEdgeLength="48dp" >

	27

	28 <LinearLayout

	29 android:id="@+id/scrolling_content"

	30 android:layout_width="match_parent"

	31 android:layout_height="wrap_content"

	32 android:orientation="vertical">

	33

	34 <!-- The layout_width/layout_height is set to 16/9 dynamically i n Java -->

	35 <TextView

	36 android:id="@+id/chooser_title"

	37 android:layout_width="match_parent"

	38 android:layout_height="wrap_content"

	39 android:gravity="bottom"

	40 android:paddingStart="@dimen/signin_chooser_padding"

	41 android:paddingEnd="@dimen/signin_chooser_padding"

	42 android:paddingBottom="@dimen/signin_chooser_padding"

	43 android:background="@color/signin_head_background"

	44 android:textColor="@color/default_text_color"

	45 android:textSize="@dimen/fre_title_text_size"

	46 android:text="@string/search_engine_dialog_title" />

	47

	48 <View
	Ted C 2017/05/04 00:16:56 I assume this can't use the Divider style? https: I assume this can't use the Divider style? https://cs.chromium.org/chromium/src/chrome/android/java/res/values-v17/style... gone 2017/05/04 00:28:11 Was intentionally not breaking from the sign in pa Show quoted text On 2017/05/04 00:16:56, Ted C wrote: > I assume this can't use the Divider style? > https://cs.chromium.org/chromium/src/chrome/android/java/res/values-v17/style... Was intentionally not breaking from the sign in page layout. I'll change both. Doubt anyone will notice the difference between 8% black and google_grey_300.
	49 android:layout_width="match_parent"

	50 android:layout_height="1dp"

	51 android:layout_marginBottom="@dimen/signin_chooser_padding"

	52 android:background="@color/signin_border_line_color"

	53 android:alpha="0.08"/>

	54

	55 <org.chromium.chrome.browser.widget.RadioButtonLayout

	56 android:id="@+id/engine_controls"

	57 android:layout_width="match_parent"

	58 android:layout_height="wrap_content"

	59 android:layout_marginStart="12dp"

	60 android:layout_marginEnd="@dimen/signin_chooser_padding" />

	61 </LinearLayout>

	62 </org.chromium.chrome.browser.firstrun.FirstRunChooserView>

	63 </FrameLayout>

	64

	65 <TextView

	66 android:layout_width="match_parent"

	67 android:layout_height="wrap_content"

	68 android:text="@string/search_engine_dialog_footer"

	69 android:textColor="@color/descriptive_text_color"

	70 android:textSize="@dimen/fre_normal_text_size"

	71 android:paddingStart="@dimen/signin_chooser_padding"
	Ted C 2017/05/04 00:16:56 use android:padding= to replace these four? use android:padding= to replace these four? gone 2017/05/04 00:28:11 Done. Show quoted text On 2017/05/04 00:16:56, Ted C wrote: > use android:padding= to replace these four? Done.
	72 android:paddingEnd="@dimen/signin_chooser_padding"

	73 android:paddingTop="@dimen/signin_chooser_padding"

	74 android:paddingBottom="@dimen/signin_chooser_padding" />

	75

	76 <!--suppress ButtonStyle -->

	77 <org.chromium.ui.widget.ButtonCompat

	78 android:id="@+id/button_primary"

	79 android:layout_width="wrap_content"

	80 android:layout_height="36dp"

	81 android:layout_gravity="end"

	82 android:layout_marginBottom="16dp"

	83 android:layout_marginStart="16dp"

	84 android:layout_marginEnd="22dp"

	85 android:paddingStart="@dimen/fre_button_padding"

	86 android:paddingEnd="@dimen/fre_button_padding"

	87 android:text="@string/ok"

	88 android:textAllCaps="true"

	89 android:textColor="@android:color/white"

	90 android:textSize="14sp"

	91 chrome:buttonColor="@color/light_active_color"

	92 chrome:buttonRaised="false" />

	93

	94 </LinearLayout>

OLD	NEW